Comment 4 for bug 1228333

Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

@Alex,

From code it looks like:

  const char* binlog_opt= (opt_bin_logname ? WSREP_SST_OPT_BINLOG : "");
  const char* binlog_opt_val= (opt_bin_logname ? opt_bin_logname : "");

MySQL [(none)]> show global variables like '%log_bin%';
+---------------------------------+-------+
| Variable_name | Value |
+---------------------------------+-------+
| log_bin | OFF |
| log_bin_basename | |
| log_bin_index | |
| log_bin_trust_function_creators | ON |
| log_bin_use_v1_row_events | OFF |
| sql_log_bin | ON |
+---------------------------------+-------+
6 rows in set (0.00 sec)

===============================================================================

So, it is "OFF" by default if not set, https://dev.mysql.com/doc/refman/5.6/en/replication-options-binary-log.html#sysvar_log_bin also confirms it.

So, a different alternative needs to be used for ' const char* binlog_opt= (opt_bin_logname ? WSREP_SST_OPT_BINLOG : ""); '

  bool binlog_on= mysql_bin_log.is_open() && thd->variables.sql_log_bin;

from transaction.cc looks good.