bootstrap-pxc and start does not check if mysqld is already running

[Martin Arrieta]

"/etc/init.d/mysql start" and "/etc/init.d/mysql bootstrap-pxc" doesn't check if mysqld is already running before start the process and return "Success" always.

-----------------
How to reproduce:
-----------------

[root@node1 vagrant]# ps xa | grep mysqld
 3908 pts/0 S 0:00 /bin/sh /usr/bin/mysqld_safe --datadir=/var/lib/mysql --pid-file=/var/lib/mysql/node1.pid
 4134 pts/0 Sl 0:00 /usr/sbin/mysqld --basedir=/usr --datadir=/var/lib/mysql --plugin-dir=/usr/lib64/mysql/plugin --user=mysql --log-error=/var/lib/mysql/error.log --pid-file=/var/lib/mysql/node1.pid --wsrep_start_position=4dc84ac4-fe3f-11e2-900b-8e2af1d75a87:105

[root@node1 vagrant]# /etc/init.d/mysql start
Starting MySQL (Percona XtraDB Cluster) SUCCESS!
[root@node1 vagrant]# echo $?
0
[root@node1 vagrant]# /etc/init.d/mysql bootstrap-pxc
Bootstrapping PXC (Percona XtraDB Cluster)Starting MySQL (Percona XtraDB Cluster) SUCCESS!
[root@node1 vagrant]# echo $?
0

-----------
How to fix
-----------

Check if mysql is already running before start the server:

# diff /etc/init.d/mysql-new /etc/init.d/mysql
285,293d284
< # Check if mysqld is already running
< if test -s "$mysqld_pid_file_path" ; then
< read mysqld_pid < "$mysqld_pid_file_path"
< if kill -0 $mysqld_pid 2>/dev/null ; then
< log_failure_msg "MySQL (Percona XtraDB Cluster) is already running ($mysqld_pid)"
< exit 1
< fi
< fi
<

[root@node1 vagrant]# /etc/init.d/mysql-new bootstrap-pxc
Bootstrapping PXC (Percona XtraDB Cluster) ERROR! MySQL (Percona XtraDB Cluster) is already running (4134)
[root@node1 vagrant]# echo $?
1
[root@node1 vagrant]# /etc/init.d/mysql-new start
 ERROR! MySQL (Percona XtraDB Cluster) is already running (4134)
[root@node1 vagrant]# echo $?
1

This will only check for the pid file, we can also add another check for the mysqld process.

Regards,

Martin.

[Raghavendra D Prabhu (raghavendra-prabhu)]

Yes, the CentOS init script didn't check that whereas the debian one did. Fixing it.

[Alex Yurchenko (ayurchen)]

fix here: http://bazaar.launchpad.net/~percona-core/percona-xtradb-cluster/5.5/revision/462

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXC-1418