Make MacOSX and FreeBSD ports
Bug #1201893 reported by
Vladislav Klyachin
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Galera |
Fix Released
|
Medium
|
Vladislav Klyachin | ||
MySQL patches by Codership |
Fix Released
|
Undecided
|
Vladislav Klyachin | ||
Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Some files in wsrep patch contain platform-dependend code.
For example in sql/wsrep_utils.c:
// try to find the address of the first one
#if (TARGET_OS_LINUX == 1)
const char cmd[] = "ip addr show | grep -E '^\\s*inet' | grep -m1 global |"
#elif defined(__sun__)
const char cmd[] = "/sbin/ifconfig -a | "
"
#else
char *cmd;
#error "OS not supported"
#endif
also scripts files ./scripts/*.sh
It is required to make the code portable or to add support for MacOSX and FreeBSD.
Related branches
lp:~codership/galera/23.2.x
(Merged)
lp:galera
Ready for review
for merging
into
lp:~dbpercona/galera/Bug1348714
- David Bennett: Pending requested
- Diff: 0 lines
Changed in codership-mysql: | |
assignee: | nobody → Vladislav Klyachin (klyachin) |
Changed in percona-xtradb-cluster: | |
status: | New → Fix Committed |
Changed in codership-mysql: | |
status: | Fix Committed → Fix Released |
Changed in galera: | |
status: | Fix Committed → Fix Released |
Changed in percona-xtradb-cluster: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The 'ip addr show/ifconfig' method also fails on many non-trivial setups (as seen from previous bugs), getifaddrs (http:// man7.org/ linux/man- pages/man3/ getifaddrs. 3.html) is more appropriate.