--defaults-group getting ignored

[Zsolt Nagy]

--defaults-group=client_group1 not passed to xtrabackup

/usr/bin/innobackupex --defaults-file=/some_path/backup.my.cnf --defaults-group=client_group1 --slave-info --rsync --
compress --parallel=8 --compress-threads=8 /backup_path/

nnoDB Backup Utility v1.5.1-xtrabackup; Copyright 2003, 2009 Innobase Oy
and Percona LLC and/or its affiliates 2009-2013. All Rights Reserved.

This software is published under
the GNU GENERAL PUBLIC LICENSE Version 2, June 1991.

Get the latest version of Percona XtraBackup, documentation, and help resources:
http://www.percona.com/xb/p

150414 13:22:57 innobackupex: Connecting to MySQL server with DSN 'dbi:mysql:;mysql_read_default_file=/some_path/backup.my.cnf;mysql_read_default_group=xtrabackup' (using password: NO).
innobackupex: got a fatal error with the following stacktrace: at /usr/bin/innobackupex line 3003
    main::mysql_connect('abort_on_error', 1) called at /usr/bin/innobackupex line 1539
innobackupex: Error: Failed to connect to MySQL server: DBI connect(';mysql_read_default_file=/some_path/backup.my.cnf;mysql_read_default_group=xtrabackup','',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/bin/innobackupex line 2987

Sample backup.my.cnf values:
[client_group1]
user = backupuser
password = "password"
socket = /socket_path/socket

[Sergei Glushchenko (sergei.glushchenko)]

Ignored by innobackupex.pl when it comes to connecting to MySQL.
Suggested fix:

--- a/storage/innobase/xtrabackup/innobackupex.pl
+++ b/storage/innobase/xtrabackup/innobackupex.pl
@@ -2940,7 +2940,7 @@ sub parse_connection_options {
         $con->{dsn} .= ";mysql_read_default_file=$option_defaults_extra_file";
     }

- $con->{dsn} .= ";mysql_read_default_group=xtrabackup";
+ $con->{dsn} .= ";mysql_read_default_group=$option_defaults_group";

     if ($option_mysql_password) {
         $con->{dsn_password} = "$option_mysql_password";

[Sergei Glushchenko (sergei.glushchenko)]

On the other hand, --defaults-group supposed to specify group to read server options from. It won't be correct to use it as an argument to specify the group to read connection options from. In 2.2 we still read server options from my.cnf, at least in xtrabackup binary.

Probably different option might be added.

[Zsolt Nagy (zs-linux)]

According to 2.2.6 release note:
"Percona XtraBackup now reads server options from SHOW VARIABLES rather than my.cnf configuration file"
http://www.percona.com/doc/percona-xtrabackup/2.2/release-notes/2.2/2.2.6.html

and it works, more or less
https://bugs.launchpad.net/percona-xtrabackup/+bug/1443991

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-722