| 2013-01-14 09:01:26 |
Alexey Kopytov |
bug |
|
|
added bug |
| 2013-01-14 09:01:42 |
Alexey Kopytov |
tags |
|
low-hanging-fruit |
|
| 2013-01-14 09:01:49 |
Alexey Kopytov |
nominated for series |
|
percona-xtrabackup/2.0 |
|
| 2013-01-14 09:01:49 |
Alexey Kopytov |
bug task added |
|
percona-xtrabackup/2.0 |
|
| 2013-01-14 09:01:49 |
Alexey Kopytov |
nominated for series |
|
percona-xtrabackup/2.1 |
|
| 2013-01-14 09:01:49 |
Alexey Kopytov |
bug task added |
|
percona-xtrabackup/2.1 |
|
| 2013-01-14 09:01:56 |
Alexey Kopytov |
percona-xtrabackup/2.0: status |
New |
Triaged |
|
| 2013-01-14 09:02:00 |
Alexey Kopytov |
percona-xtrabackup/2.1: status |
New |
Triaged |
|
| 2013-01-14 09:02:04 |
Alexey Kopytov |
percona-xtrabackup/2.0: importance |
Undecided |
Low |
|
| 2013-01-14 09:02:06 |
Alexey Kopytov |
percona-xtrabackup/2.1: importance |
Undecided |
Low |
|
| 2013-01-14 09:02:09 |
Alexey Kopytov |
percona-xtrabackup/2.0: milestone |
|
2.0.6 |
|
| 2013-01-14 09:02:55 |
Alexey Kopytov |
description |
innobackupex --slave-info executes the following code to get the master binlog coordinates for CHANGE MASTER TO written xtrabackup_slave_info:
mysql_send 'SHOW SLAVE STATUS\G';
# get output of the "show slave status" command from mysql output
# and extract binlog position of the master server
file_to_array($mysql_stdout, \@lines);
for (@lines) {
$master = $1 if /Master_Host:\s*(\S*)\s*$/;
$filename = $1 if /Master_Log_File:\s*(\S*)\s*$/;
$position = $1 if /Master_Log_Pos:\s*(\S*)\s*$/;
}
That code works, but there's a couple of problems with it, making it dependent on specific SHOW SLAVE STATUS output format:
- we actually want to read Relay_Master_Log_File rather than Master_Log_File. And we do read it, but only because Relay_Master_Log_File happens to be after Master_Log_File in the SHOW SLAVE STATUS output, so the previously read Master_Log_File (incorrect) is later overwritten by the Relay_Master_Log_File value (i.e. the correct one)
- there's not column in the SHOW SLAVE STATUS output named "Master_Log_Pos", but there are "Read_Master_Log_Pos" and "Exec_Master_Log_Pos". Again, we need the latter value for --slave-info, and we are just lucky it goes after Read_Master_Log_Pos.
The fix is to change the column names in the above code to not depend on specific order and other column naming in SHOW SLAVE STATUS. |
innobackupex --slave-info executes the following code to get the master binlog coordinates for CHANGE MASTER TO written xtrabackup_slave_info:
mysql_send 'SHOW SLAVE STATUS\G';
# get output of the "show slave status" command from mysql output
# and extract binlog position of the master server
file_to_array($mysql_stdout, \@lines);
for (@lines) {
$master = $1 if /Master_Host:\s*(\S*)\s*$/;
$filename = $1 if /Master_Log_File:\s*(\S*)\s*$/;
$position = $1 if /Master_Log_Pos:\s*(\S*)\s*$/;
}
That code works, but there's a couple of problems with it, making it dependent on specific SHOW SLAVE STATUS output format:
- we actually want to read Relay_Master_Log_File rather than Master_Log_File. And we do read it, but only because Relay_Master_Log_File happens to be after Master_Log_File in the SHOW SLAVE STATUS output, so the previously read Master_Log_File value (incorrect) is later overwritten by the Relay_Master_Log_File value (i.e. the correct one)
- there's no column in the SHOW SLAVE STATUS output named "Master_Log_Pos", but there are "Read_Master_Log_Pos" and "Exec_Master_Log_Pos". Again, we need the latter value for --slave-info, and we are just lucky it goes after Read_Master_Log_Pos.
The fix is to change the column names in the above code to not depend on specific order and other column naming in SHOW SLAVE STATUS. |
|
| 2013-01-14 11:58:35 |
Alexey Kopytov |
branch linked |
|
lp:~akopytov/percona-xtrabackup/use-dbd-mysql-in-innobackupex |
|
| 2013-03-06 07:27:48 |
Alexey Kopytov |
percona-xtrabackup/2.0: milestone |
2.0.6 |
2.0.7 |
|
| 2013-03-11 12:26:58 |
Alexey Kopytov |
percona-xtrabackup/2.1: assignee |
|
Alexey Kopytov (akopytov) |
|
| 2013-03-11 12:27:01 |
Alexey Kopytov |
percona-xtrabackup/2.1: milestone |
|
2.1-pre-initial-release |
|
| 2013-03-11 12:27:04 |
Alexey Kopytov |
percona-xtrabackup/2.1: status |
Triaged |
Fix Released |
|
| 2013-04-29 09:15:03 |
Alexey Kopytov |
percona-xtrabackup/2.0: milestone |
2.0.7 |
2.1.0 |
|
| 2013-04-29 09:15:11 |
Alexey Kopytov |
percona-xtrabackup/2.0: milestone |
2.1.0 |
2.0.8 |
|
| 2014-08-22 13:40:34 |
Alexey Kopytov |
percona-xtrabackup/2.0: status |
Triaged |
Won't Fix |
|
| 2014-08-22 13:40:38 |
Alexey Kopytov |
percona-xtrabackup/2.0: milestone |
future-2.0-releases |
|
|
