Possibly wrong posix_fadvise hints

Reported by Laurynas Biveinis on 2012-02-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup
Low
Alexey Kopytov
2.0
Low
Alexey Kopytov

Bug Description

posix_fadvise usage in XtraBackup sources have to be audited. Superficially at least some of them look wrong, i.e. POSIX_FADV_DONTNEED before file access.

Related branches

Changed in percona-xtrabackup:
milestone: none → 1.9.3
assignee: nobody → Alexey Kopytov (akopytov)
status: Confirmed → In Progress
Alexey Kopytov (akopytov) wrote :

The problem was that posix_fadvise(POSIX_FADV_DONTNEED) was used
incorrectly, because the call just releases already cached pages from
the pagecache, thus making a single-shot call before file access
useless.

Fixed by making sure the call is invoked after each read/write to
make the feature work as advertised.

Changed in percona-xtrabackup:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers