missing --redo-only in docs for preparing an incremental backup with innobackupex

Bug #919203 reported by Alexey Kopytov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup moved to https://jira.percona.com/projects/PXB
Fix Released
Undecided
Hrvoje Matijakovic

Bug Description

http://www.percona.com/doc/percona-xtrabackup/innobackupex/incremental_backups_innobackupex.html#preparing-an-incremental-backup-with-innobackupex says that:

"
Then, the first incremental backup can be applied to the base backup, by issuing:

innobackupex --apply-log BASE-DIR --incremental-dir=INCREMENTAL-DIR-1
"

However, that command should have the --redo-only option is well, as it's required to apply an incremental backup, and the corresponding xtrabackup option (--apply-log-only) is mentioned in the xtrabackup binary docs: http://www.percona.com/doc/percona-xtrabackup/xtrabackup_bin/incremental_backups.html?id=percona-xtrabackup:xtrabackup:incremental#preparing-the-incremental-backups

Tags: doc

Related branches

tags: added: doc
Changed in percona-xtrabackup:
status: New → Confirmed
assignee: nobody → Hrvoje Matijakovic (hrvojem)
description: updated
Changed in percona-xtrabackup:
status: Confirmed → In Progress
Changed in percona-xtrabackup:
status: In Progress → Fix Committed
Changed in percona-xtrabackup:
status: Fix Committed → Fix Released
Revision history for this message
Gregor Hoffleit (flight) wrote :

How about the second incremental backup (and any subsequent)? Doesn't it also need a "--redo-only"?

Currently, the "--redo-only" is missing from the command line suggested for applying subsequent backups ("incremental_backups_innobackupex.html"):

"Repeat the procedure with the second one:

innobackupex --apply-log BASE-DIR --incremental-dir=INCREMENTAL-DIR-2
If the “completed OK!” message was shown, the final data will be in the base backup directory, BASE-DIR.

You can use this procedure to add more increments to the base, as long as you do it in the chronological order that the backups were done. If you omit this order, the backup will be useless. If you have doubts about the order that they must be applied, you can check the file xtrabackup_checkpoints at the directory of each one, as shown in the beginning of this section."

I would have thought this this was the full procedure for preparing a backup from a full and several incremental backups:

innobackupex --apply-log --redo-only BASE-DIR
innobackupex --apply-log --redo-only BASE-DIR --incremental-dir=INCREMENTAL-DIR-1
innobackupex --apply-log --redo-only BASE-DIR --incremental-dir=INCREMENTAL-DIR-2
...
innobackupex --apply-log --redo-only BASE-DIR --incremental-dir=INCREMENTAL-DIR-x
innobackupex --apply-log BASE-DIR"

Is this true? Then "incremental_backups_innobackupex.html" should be changed accordingly.

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Good question. --redo-only should be used when applying all incremental backups except the last one. I will report it as a separate bug.

Revision history for this message
Alexey Kopytov (akopytov) wrote :
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-1146

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.