Incorrect patching instructions in BUILD.txt

Reported by Sasha Pachev on 2011-03-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup
Low
Rodrigo Gadea
1.6
Low
Rodrigo Gadea
2.0
Low
Rodrigo Gadea

Bug Description

The patching instructions to prepare MySQL source for xtrabackup build in BUILD.txt say the following:

3. For 5.1x you need to apply a patch.
   From the innobase directory, apply the xtrabackup patch.
  e.g. #patch -p2 < xtrabackup-0.0/fix_innodb_for_backup51.patch

Those instructions are out of date and the patch fails to apply. The correct command is:

patch -p1 < storage/innobase/xtrabackup-1.5/fix_innodb_for_backup55.patch

for version 5.5 and

patch -p1 < storage/innobase/xtrabackup-1.5/fix_innodb_for_backup55.patch

for version 5.1, and both should be applied from the MySQL source root.

Valentine Gostev (longbow) wrote :

Additional note:
BUILD.TXT should contain also instruction for scripted build process and manual one.
The documentation in subject file should be in sync with http://www.percona.com/docs/wiki/percona-xtrabackup:installation:from-source.

Changed in percona-xtrabackup:
status: New → Confirmed
assignee: nobody → Rodrigo Gadea (rodrigo-gadea-percona)
milestone: none → 1.6.2
importance: Undecided → Low
Changed in percona-xtrabackup:
status: Confirmed → In Progress
Changed in percona-xtrabackup:
status: In Progress → Fix Committed
Stewart Smith (stewart) on 2011-07-19
Changed in percona-xtrabackup:
milestone: 1.6.2 → 1.6.3
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers