innobackupex doesn't include fast-checksums into generated my.cnf

Reported by Baron Schwartz on 2011-03-12
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Percona XtraBackup
High
Sergei Glushchenko
1.6
High
Sergei Glushchenko
2.0
High
Sergei Glushchenko

Bug Description

A user reports at http://forum.percona.com/index.php/m/6750/ that the backup-my.cnf file generated and placed into the backup doesn't include fast-checksums, and therefore the preparation stage fails when run on a different server that doesn't have this parameter included in the my.cnf file.

Vadim Tkachenko (vadim-tk) wrote :

To QA: That also may be problem with innodb_page_size and innodb_log_block_size

Changed in percona-xtrabackup:
assignee: nobody → Valentine Gostev (core-longbow)
Valentine Gostev (longbow) wrote :

Only these six options are written to $backup_config_file:

sub write_backup_config_file {
<snip>
 print FILE "# This MySQL options file was generated by $innobackup_script.\n\n" .
          "# The MySQL server\n" .
          "[mysqld]\n" .
          "datadir=$root\n" .
          "innodb_data_home_dir=$root\n" .
          "innodb_data_file_path=$innodb_data_file_path\n" .
          "innodb_log_group_home_dir=$root\n" .
          "innodb_log_files_in_group=$innodb_log_files_in_group\n" .
          "innodb_log_file_size=$innodb_log_file_size\n";
    close(FILE);

Changed in percona-xtrabackup:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 1.7
Valentine Gostev (longbow) wrote :

All other options are not reflected in backup-my.cnf

Stewart Smith (stewart) wrote :

Setting to critical as can create backups that appear to be unrestorable/corrupt.

Changed in percona-xtrabackup:
assignee: Valentine Gostev (longbow) → nobody
importance: Medium → Critical
status: Confirmed → Triaged
Stewart Smith (stewart) on 2012-01-11
tags: added: low-hanging-fruit
Alexey Kopytov (akopytov) wrote :

This was actually released in 1.9.0, but wasn't targeted to a milestone and is thus missing in release notes.

Hi - can we have this re-verified for release 2.0.1?

I'm seeing the following block of code still in the 2.0.1 rpm and binary downloads:

http://www.percona.com/downloads/XtraBackup/XtraBackup-2.0.1/binary/Linux/x86_64/percona-xtrabackup-2.0.1-446.tar.gz
-and-
http://www.percona.com/downloads/XtraBackup/XtraBackup-2.0.1/RPM/rhel6/x86_64/percona-xtrabackup-2.0.1-446.rhel6.x86_64.rpm

#
# write_backup_config_file subroutine creates a backup options file for
# ibbackup program. It writes to the file only those options that
# are required by ibbackup.
# Parameters:
# filename name for the created options file
#
sub write_backup_config_file {
    my $filename = shift;

    if (!$option_remote_host) {
        open(FILE, "> $filename") || Die "Failed to open file '$filename': $!";
    } else {
        open(FILE, "| ssh $option_ssh_opt $option_remote_host 'cat > $filename'")
            || Die "Failed to open file '$option_remote_host:$filename': $!";
    }

    my @option_names = (
        "innodb_data_file_path",
        "innodb_log_files_in_group",
        "innodb_log_file_size",
        "innodb_fast_checksum",
        "innodb_page_size",
        "innodb_log_block_size",
        );

Many thanks in advance
Patrick

My apologies for the spam on this - I see that this bug is for ADDING the innodb_fast_checksum to the backup-my.cnf file.

<Face palm> - my bad - although I'm actually wanting to have it removed from the backup-my.cnf file creation - it's creating problems for me when I'm trying to verify a backup using the backup-my.cnf file.

Again - my apologies for the spam - please remove the previous comment if desired.

Patrick

Alexey Kopytov (akopytov) wrote :

Patrick,

As seen from this bug description, to prepare the backup, innodb_fast_checksum must be present in backup-my.cnf if it was enabled in the server.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers