innobackupex ignores --ibbackup
Bug #729497 reported by
Baron Schwartz
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
High
|
Stewart Smith | ||
1.6 |
Fix Released
|
High
|
Stewart Smith |
Bug Description
innobackupex ignores what you set for --ibbackup, and calls set_xtrabackup_
241c242
< } else {
---
> } elsif ($option_
Note: I do NOT know if this causes any other bugs or really fixes the problem -- in the exact specific problem I was having, the code inside of set_xtrabackup_
Related branches
lp:~stewart/percona-xtrabackup/bug729497-ignores-ibbackup
- Valentine Gostev (community): Approve (qa)
- Vadim Tkachenko: Approve
-
Diff: 12 lines (+1/-1)1 file modifiedinnobackupex (+1/-1)
lp:~stewart/percona-xtrabackup/1.6-testsuite-fixes
- Percona developers: Pending requested
-
Diff: 18017 lines (+16942/-219)86 files modifiedtest/bootstrap.sh (+88/-0)
test/experimental/xb_race_drop.sh (+0/-2)
test/inc/common.sh (+63/-114)
test/python/BytesIO.py (+136/-0)
test/python/iso8601/LICENSE (+20/-0)
test/python/iso8601/README (+26/-0)
test/python/iso8601/README.subunit (+5/-0)
test/python/iso8601/setup.py (+58/-0)
test/python/iso8601/test_iso8601.py (+111/-0)
test/python/junitxml/__init__.py (+221/-0)
test/python/junitxml/tests/__init__.py (+16/-0)
test/python/junitxml/tests/test_junitxml.py (+327/-0)
test/python/subunit/__init__.py (+1250/-0)
test/python/subunit/chunked.py (+185/-0)
test/python/subunit/details.py (+119/-0)
test/python/subunit/iso8601.py (+133/-0)
test/python/subunit/progress_model.py (+106/-0)
test/python/subunit/run.py (+73/-0)
test/python/subunit/test_results.py (+492/-0)
test/python/subunit/tests/TestUtil.py (+80/-0)
test/python/subunit/tests/__init__.py (+41/-0)
test/python/subunit/tests/sample-script.py (+21/-0)
test/python/subunit/tests/sample-two-script.py (+7/-0)
test/python/subunit/tests/test_chunked.py (+152/-0)
test/python/subunit/tests/test_details.py (+112/-0)
test/python/subunit/tests/test_progress_model.py (+118/-0)
test/python/subunit/tests/test_subunit_filter.py (+208/-0)
test/python/subunit/tests/test_subunit_stats.py (+84/-0)
test/python/subunit/tests/test_subunit_tags.py (+69/-0)
test/python/subunit/tests/test_tap2subunit.py (+445/-0)
test/python/subunit/tests/test_test_protocol.py (+1299/-0)
test/python/subunit/tests/test_test_results.py (+300/-0)
test/python/testtools/__init__.py (+80/-0)
test/python/testtools/_spinner.py (+316/-0)
test/python/testtools/compat.py (+286/-0)
test/python/testtools/content.py (+238/-0)
test/python/testtools/content_type.py (+33/-0)
test/python/testtools/deferredruntest.py (+335/-0)
test/python/testtools/distutilscmd.py (+62/-0)
test/python/testtools/helpers.py (+64/-0)
test/python/testtools/matchers.py (+785/-0)
test/python/testtools/monkey.py (+97/-0)
test/python/testtools/run.py (+332/-0)
test/python/testtools/runtest.py (+200/-0)
test/python/testtools/testcase.py (+724/-0)
test/python/testtools/testresult/__init__.py (+19/-0)
test/python/testtools/testresult/doubles.py (+111/-0)
test/python/testtools/testresult/real.py (+621/-0)
test/python/testtools/tests/__init__.py (+44/-0)
test/python/testtools/tests/helpers.py (+72/-0)
test/python/testtools/tests/test_compat.py (+257/-0)
test/python/testtools/tests/test_content.py (+223/-0)
test/python/testtools/tests/test_content_type.py (+46/-0)
test/python/testtools/tests/test_deferredruntest.py (+738/-0)
test/python/testtools/tests/test_distutilscmd.py (+90/-0)
test/python/testtools/tests/test_fixturesupport.py (+79/-0)
test/python/testtools/tests/test_helpers.py (+106/-0)
test/python/testtools/tests/test_matchers.py (+695/-0)
test/python/testtools/tests/test_monkey.py (+167/-0)
test/python/testtools/tests/test_run.py (+77/-0)
test/python/testtools/tests/test_runtest.py (+300/-0)
test/python/testtools/tests/test_spinner.py (+332/-0)
test/python/testtools/tests/test_testresult.py (+1372/-0)
test/python/testtools/tests/test_testsuite.py (+53/-0)
test/python/testtools/tests/test_testtools.py (+1143/-0)
test/python/testtools/tests/test_with_with.py (+42/-0)
test/python/testtools/testsuite.py (+87/-0)
test/python/testtools/utils.py (+13/-0)
test/run.sh (+140/-14)
test/subunit.sh (+56/-0)
test/subunit2junitxml (+65/-0)
test/t/bug606981.sh (+8/-6)
test/t/ib_csm_csv.sh (+3/-5)
test/t/ib_incremental.sh (+8/-9)
test/t/ib_partition.sh (+0/-4)
test/t/ib_specialchar.sh (+3/-6)
test/t/xb_basic.sh (+3/-5)
test/t/xb_export.sh (+12/-8)
test/t/xb_incremental.sh (+7/-7)
test/t/xb_incremental_compressed.sh (+15/-13)
test/t/xb_parallel.sh (+3/-5)
test/t/xb_part_range.sh (+0/-3)
test/t/xb_partial.sh (+3/-4)
test/t/xb_stats.sh (+6/-8)
test/t/xb_stream.sh (+3/-5)
utils/build.sh (+3/-1)
tags: | added: cr15286 |
tags: |
added: cr i15286 removed: cr15286 |
Changed in percona-xtrabackup: | |
status: | New → Confirmed |
importance: | Undecided → High |
milestone: | none → 1.7 |
Changed in percona-xtrabackup: | |
assignee: | nobody → Stewart Smith (stewart) |
Changed in percona-xtrabackup: | |
status: | Confirmed → In Progress |
Changed in percona-xtrabackup: | |
status: | In Progress → Fix Committed |
Changed in percona-xtrabackup: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Tested this logic change and it seems to work just fine. The checking for whether the binary exists and is valid is not as exhaustive as in the if($option_ apply_log) section, but at least it makes the option useable.
I'm finding this necessary to avoid some crashes when performing apply-log using xtrabackup_51 binary (result of MySQL bug in InnoDB that it is linked against).