utils/build.sh does not work in plugin mode

Bug #681789 reported by Stefan Priebe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup moved to https://jira.percona.com/projects/PXB
Fix Released
Undecided
Unassigned

Bug Description

Version: xtrabackup 1.4 stable source tarball.

Hello,

as we're using the innodb plugin i wanted to build xtrabackup with plugin option using the provided utils/build.sh script.

But then i'm resulting in:
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../include -I../../include -I../../include -I../../regex -I./include -I../../sql -I. -I../../zlib -DMYSQL_DYNAMIC_PLUGIN -g -DUNIV_LINUX -DUNIV_LINUX -MT ha_innodb_plugin_la-fil0fil.lo -MD -MP -MF .deps/ha_innodb_plugin_la-fil0fil.Tpo -c fil/fil0fil.c -fPIC -DPIC -o .libs/ha_innodb_plugin_la-fil0fil.o
fil/fil0fil.c: In function 'fil_open_single_table_tablespace':
fil/fil0fil.c:3005: error: 'pars_info_t' undeclared (first use in this function)
fil/fil0fil.c:3005: error: (Each undeclared identifier is reported only once
fil/fil0fil.c:3005: error: for each function it appears in.)
fil/fil0fil.c:3005: error: 'info' undeclared (first use in this function)
fil/fil0fil.c: In function 'fil_space_for_table_exists_in_mem':
fil/fil0fil.c:3799: error: 'pars_info_t' undeclared (first use in this function)
fil/fil0fil.c:3799: error: 'info' undeclared (first use in this function)
make[2]: *** [ha_innodb_plugin_la-fil0fil.lo] Error 1
make[2]: Leaving directory `/xtrabackup-1.4/mysql-5.1.46/storage/innodb_plugin'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/xtrabackup-1.4/mysql-5.1.46/storage'
make: *** [all-recursive] Error 1

Stefan

Related branches

Revision history for this message
Stefan Priebe (s-priebe) wrote :

i've used the autodownload switch so the version should be also correct

Revision history for this message
Stefan Priebe (s-priebe) wrote :

sorry me again. The autodownload uses 5.1.46 is it a problem to use the compiled xtrabackup then with 5.1.51?

Revision history for this message
Stefan Priebe (s-priebe) wrote :

xtrabackup trunk does the same :-(

Revision history for this message
Stefan Priebe (s-priebe) wrote :

or is it safe to use the build.sh to build against 5.1 and then use that one against 5.1 with innodb plugin.

Revision history for this message
Stefan Priebe (s-priebe) wrote :

I could fix this by doing this:

--- fix_innodb_for_backup_5.1_plugin_1.0.7.patch.orig 2010-11-18 10:29:43.000000000 +0100
+++ fix_innodb_for_backup_5.1_plugin_1.0.7.patch 2010-11-29 09:30:13.000000000 +0100
@@ -143,6 +143,15 @@ diff -ru mysql-5.1.46_orig/storage/innod
 diff -ru mysql-5.1.46_orig/storage/innodb_plugin/fil/fil0fil.c mysql-5.1.46/storage/innodb_plugin/fil/fil0fil.c
 --- mysql-5.1.46_orig/storage/innodb_plugin/fil/fil0fil.c 2010-04-06 23:07:12.000000000 +0900
 +++ mysql-5.1.46/storage/innodb_plugin/fil/fil0fil.c 2010-08-24 19:04:11.158519001 +0900
+@@ -25,6 +25,8 @@ Created 10/25/1995 Heikki Tuuri
+
+ #include "fil0fil.h"
+
++#include "pars0pars.h"
++
+ #include "mem0mem.h"
+ #include "hash0hash.h"
+ #include "os0file.h"
 @@ -283,7 +283,7 @@

  /** The tablespace memory cache. This variable is NULL before the module is

Revision history for this message
Vadim Tkachenko (vadim-tk) wrote :

Stefan

Sorry, we do not support _plugin build.
To make backups for InnoDB-plugin please use "xtradb" builds.

Changed in percona-xtrabackup:
status: New → Won't Fix
Revision history for this message
Stefan Priebe (s-priebe) wrote :

sorry totally confused.

> Sorry, we do not support _plugin build.
Why do you (percona) deliver then a patch for the plugin and also allow the plugin build via utils script.

>To make backups for InnoDB-plugin please use "xtradb" builds.
What means xtradb build?

Revision history for this message
Vadim Tkachenko (vadim-tk) wrote :

Stefan,

You can use
utils/build.sh xtradb
to build binary based on Percona Server/XtraDB

Revision history for this message
Stefan Priebe (s-priebe) wrote :

And then i should use the resulting binary for MySQL with InnoDB plugin?

Revision history for this message
Vadim Tkachenko (vadim-tk) wrote :

Stefan

Yes.

Revision history for this message
Stefan Priebe (s-priebe) wrote :

Should this also be used for inbuild innodb plugin?

Revision history for this message
Vadim Tkachenko (vadim-tk) wrote : Re: [Bug 681789] Re: utils/build.sh does not work in plugin mode

if you build "xtradb" mode it is to use with InnoDB-plugin.
If you are looking to backup regular InnoDB, you should build "5.1" mode.

On Tue, Nov 30, 2010 at 11:40 AM, Stefan Priebe
<email address hidden> wrote:
> Should this also be used for inbuild innodb plugin?
>
> --
> utils/build.sh does not work in plugin mode
> https://bugs.launchpad.net/bugs/681789
> You received this bug notification because you are a member of Percona
> developers, which is the registrant for Percona-XtraBackup.
>
> Status in Open source backup tool for InnoDB and XtraDB: Won't Fix
>
> Bug description:
> Version: xtrabackup 1.4 stable source tarball.
>
> Hello,
>
> as we're using the innodb plugin i wanted to build xtrabackup with plugin option using the provided utils/build.sh script.
>
> But then i'm resulting in:
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../include -I../../include -I../../include -I../../regex -I./include -I../../sql -I. -I../../zlib -DMYSQL_DYNAMIC_PLUGIN -g -DUNIV_LINUX -DUNIV_LINUX -MT ha_innodb_plugin_la-fil0fil.lo -MD -MP -MF .deps/ha_innodb_plugin_la-fil0fil.Tpo -c fil/fil0fil.c  -fPIC -DPIC -o .libs/ha_innodb_plugin_la-fil0fil.o
> fil/fil0fil.c: In function 'fil_open_single_table_tablespace':
> fil/fil0fil.c:3005: error: 'pars_info_t' undeclared (first use in this function)
> fil/fil0fil.c:3005: error: (Each undeclared identifier is reported only once
> fil/fil0fil.c:3005: error: for each function it appears in.)
> fil/fil0fil.c:3005: error: 'info' undeclared (first use in this function)
> fil/fil0fil.c: In function 'fil_space_for_table_exists_in_mem':
> fil/fil0fil.c:3799: error: 'pars_info_t' undeclared (first use in this function)
> fil/fil0fil.c:3799: error: 'info' undeclared (first use in this function)
> make[2]: *** [ha_innodb_plugin_la-fil0fil.lo] Error 1
> make[2]: Leaving directory `/xtrabackup-1.4/mysql-5.1.46/storage/innodb_plugin'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/xtrabackup-1.4/mysql-5.1.46/storage'
> make: *** [all-recursive] Error 1
>
> Stefan
>
>
>

--
Vadim Tkachenko, CTO, Percona Inc.
Phone +1-888-401-3403,  Skype: vadimtk153
Schedule meeting: http://tungle.me/VadimTkachenko

Revision history for this message
Alexey Kopytov (akopytov) wrote :

This bug was fixed along with the fix for bug #683507 as I had to update the 5.1_plugin patch anyway.

Changed in percona-xtrabackup:
status: Won't Fix → Fix Committed
Changed in percona-xtrabackup:
milestone: none → 1.6
Changed in percona-xtrabackup:
status: Fix Committed → Fix Released
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-1107

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.