innobackupex --include does not apply to the non-InnoDB tables

Bug #597384 reported by Sheeri K. Cabral
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup moved to https://jira.percona.com/projects/PXB
Fix Released
Low
Valentine Gostev

Bug Description

if you use --include to specify tables to include, it will work for filtering in/out innodb tables, but not for filtering in/out other table types (ie MyISAM).

Tags: innobackupex

Related branches

Revision history for this message
Sheeri K. Cabral (awfief) wrote :

The fix, mostly stolen from earlier in the code:

*** innobackupex-1.5.1 2010-06-22 09:47:10.000000000 -0400
--- /usr/bin/innobackupex-1.5.1 2010-06-22 10:23:49.000000000 -0400
*************** sub backup_files {
*** 1916,1921 ****
--- 1916,1929 ----
              # mysql connection from timing out
              mysql_keep_alive();
              next unless check_if_required($database, $file);
+ if($option_include) {
+ if (!("$database.$file" =~ /$option_include/)) {
+ print STDERR "$database.$file is skipped because it does not match $option_include.\n";
+ next;
+ }
+ }
+
+
              if ($print_each_file) {
                  print STDERR "$prefix Backing up file '$source_dir/$database/$file'\n";
              }

Revision history for this message
Will Bryant (willbryant) wrote :

Use the --databases option.

Revision history for this message
Vadim Tkachenko (vadim-tk) wrote :

Fix commited, assigned to Valentine to provide test-case

Changed in percona-xtrabackup:
assignee: nobody → Valentine Gostev (core-longbow)
milestone: none → 1.6
status: New → Fix Committed
importance: Undecided → Low
Changed in percona-xtrabackup:
status: Fix Committed → Triaged
Changed in percona-xtrabackup:
status: Triaged → New
tags: added: innobackupex
Revision history for this message
Valentine Gostev (longbow) wrote :

I do not approve this fix. Skipped InnoDB tables are broken after restore. Please refer to bug https://bugs.launchpad.net/percona-xtrabackup/+bug/721339

Changed in percona-xtrabackup:
status: New → Triaged
status: Triaged → Confirmed
Revision history for this message
Valentine Gostev (longbow) wrote :

Disregard my prev comment, please. That relates to docs.

Changed in percona-xtrabackup:
status: Confirmed → Fix Committed
Changed in percona-xtrabackup:
status: Fix Committed → Fix Released
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-812

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.