RPM compilation with XB_VERSION_EXTRA creates a strange RPM version

[Julien Pivotto]

Context: we are building a RPM of Xtrabackup with our own patch

in the code:

if [ -z "${XB_VERSION_EXTRA:-}" ]; then
  EXTRAVER="%{nil}"
  RPM_EXTRAVER=1
else
  EXTRAVER=${XB_VERSION_EXTRA}
  RPM_EXTRAVER=.${XB_VERSION_EXTRA#-}
fi

if we set XB_VERSION_EXTRA to -foo1

it creates percona-xtrabackup-debuginfo-2.2.11-.foo1.el7.centos.x86_64.rpm. There is a extra dot.

[Julien Pivotto (roidelapluie)]

PR https://github.com/percona/percona-xtrabackup/pull/76

[Valerii Kravchuk (valerii-kravchuk)]

This is easy to confirm:

[openxs@chief percona-xtrabackup-2.2]$ grep -rn XB_VERSION_EXTRA *
cmake/mysql_version.cmake:72: MYSQL_GET_CONFIG_VALUE("XB_VERSION_EXTRA" XB_EXTRA_VERSION XB_VERSION)
storage/innobase/xtrabackup/utils/build-rpm.sh:100:XTRABACKUP_VERSION="${XB_VERSION_MAJOR}.${XB_VERSION_MINOR}.${XB_VERSION_PATCH}${XB_VERSION_EXTRA}"
storage/innobase/xtrabackup/utils/build-rpm.sh:140:if [ -z "${XB_VERSION_EXTRA:-}" ]; then
storage/innobase/xtrabackup/utils/build-rpm.sh:144: EXTRAVER=${XB_VERSION_EXTR }
storage/innobase/xtrabackup/utils/build-rpm.sh:145: RPM_EXTRAVER=.${XB_VERSION_EXTRA#-}
storage/innobase/xtrabackup/utils/build-rpm.sh:149:sed -i "s:@@XB_VERSION_EXTRA@@:${EXTRAVER}:g" SPECS/percona-xtrabackup.spec
storage/innobase/xtrabackup/utils/build-binary.sh:83:XTRABACKUP_VERSION="${XB_VERSION_MAJOR}.${XB_VERSION_MINOR}.${XB_VERSION_PATCH}${XB_VERSION_EXTRA}"
storage/innobase/xtrabackup/utils/percona-xtrabackup.spec:4:%define xb_version_extra @@XB_VERSION_EXTRA@@
storage/innobase/xtrabackup/utils/build-dpkg.sh:48:XTRABACKUP_VERSION="${XB_VERSION_MAJOR}.${XB_VERSION_MINOR}.${XB_VERSION_PATCH}${XB_VERSION_EXTRA}"
XB_VERSION:4:XB_VERSION_EXTRA=
[openxs@chief percona-xtrabackup-2.2]$

We can clearly see that extra dot for RPM_EXTRAVER.

[Nilnandan Joshi (nilnandan-joshi)]

Not valid for 2.1

nilnandan.joshi@bm-support01:~/percona-xtrabackup-2.1.9$ grep -rn XB_VERSION_EXTRA *
nilnandan.joshi@bm-support01:~/percona-xtrabackup-2.1.9$

[Sergei Glushchenko (sergei.glushchenko)]

https://github.com/percona/percona-xtrabackup/pull/88
https://github.com/percona/percona-xtrabackup/pull/89

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-730