innobackupex does not (properly) check for file open errors in some cases

[Alexey Kopytov]

There's a number of cases where the innobackupex script does not properly check for errors returned by the 'open' subroutine. There are two groups of such incorrect calls:

1. open FH, "> $file";

i.e. with no error handling at all, and

2. open FH, "> $file" || die ...

this one is incorrect, because due to the '||' operator priority in Perl it is evaluated as follows:

open FN, ("> $file" || die ...)

So it is essentially not any different from case #1, i.e. no error handling at all.

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-924