innobackupex does not (properly) check for file open errors in some cases

Bug #1375241 reported by Alexey Kopytov on 2014-09-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup moved to https://jira.percona.com/projects/PXB
Fix Released
Low
Alexey Kopytov
2.1
Won't Fix
Undecided
Unassigned
2.2
Fix Released
Low
Alexey Kopytov

Bug Description

There's a number of cases where the innobackupex script does not properly check for errors returned by the 'open' subroutine. There are two groups of such incorrect calls:

1. open FH, "> $file";

i.e. with no error handling at all, and

2. open FH, "> $file" || die ...

this one is incorrect, because due to the '||' operator priority in Perl it is evaluated as follows:

open FN, ("> $file" || die ...)

So it is essentially not any different from case #1, i.e. no error handling at all.

Related branches

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-924

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers