compact_compressed test is too slow in debug builds

Bug #1213102 reported by Alexey Kopytov on 2013-08-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup
Medium
Alexey Kopytov
2.1
Medium
Alexey Kopytov
2.2
Medium
Alexey Kopytov

Bug Description

The compact_compressed test is too slow in debug builds with most time spent in page_zip_validate(). Which is called twice per each row inserted, and does a lot of things including decompressing a page.

One way to fix this would be to disable UNIV_ZIP_DEBUG for debug XtraBackup builds. But that would remove validation for all tests.

Another way would be to disable compact_compressed for debug builds, which doesn't look good either.

A more acceptable solution seems to be to only call page_zip_validate() once per row (i.e. after inserting the row, but not before). Which would still provide good enough validation for all tests, but decrease compact_compressed execution time by ~50%.

Related branches

lp:~akopytov/percona-xtrabackup/bug1213102-2.1
Merged into lp:percona-xtrabackup/2.1 at revision 667
George Ormond Lorch III: Approve (g2) on 2013-08-20
tags: added: low-hanging-fruit
summary: - compact_compressed test is too slow
+ compact_compressed test is too slow in debug builds
description: updated
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers