xtrabackup typo: Temporary instance for recovery is set as followings
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
Low
|
Alexey Kopytov | |
| 2.0 |
Won't Fix
|
Undecided
|
Unassigned | |
| 2.1 |
Fix Released
|
Low
|
Alexey Kopytov |
Bug Description
Hi,
When following the status output of innobackupex, one of the lines prints:
xtrabackup: Temporary instance for recovery is set as followings.
I think we should say:
xtrabackup: Temporary instance for recovery is set as following:
followings isn't proper, and I think a colon makes more sense here.
Related branches
- Alexey Kopytov (community): Approve on 2013-07-08
-
Diff: 17 lines (+3/-3)1 file modifiedsrc/xtrabackup.cc (+3/-3)
Michael Coburn (michaelcoburn) wrote : | #1 |
summary: |
- innobackupex typo: xtrabackup: Temporary instance for recovery is set as - followings + xtrabackup typo: Temporary instance for recovery is set as followings |
There are more uses of "followings", all of them are probably wrong:
openxs@
Percona-
Binary file Percona-
Binary file Percona-
Percona-
percona-
percona-
Binary file percona-
Binary file percona-
percona-
Binary file src/xtrabackup.o matches
Binary file src/xtrabackup matches
src/xtrabackup.
src/xtrabackup.
openxs@
revision-id: <email address hidden>
date: 2013-07-01 16:21:20 +0400
build-date: 2013-07-05 18:18:01 +0300
revno: 621
branch-nick: percona-xtrabackup
Changed in percona-xtrabackup: | |
status: | New → Confirmed |
Alexey Kopytov (akopytov) wrote : | #3 |
I try to correct language to the best of my ability when I touch code around those messages. Which means the code that prints those messages is still from early XtraBackup versions. But OK, let's fix it.
tags: |
added: low-hanging-fruit removed: typo |
Alexey Kopytov (akopytov) wrote : | #4 |
The only "followings" occurrence which should be fixed in XtraBackup is
if (xtrabackup_backup || xtrabackup_stats) {
msg("xtrabackup: Target instance is assumed as followings.\n");
} else {
msg("xtrabackup: Temporary instance for recovery is set as "
"
}
Everything else mentioned in comment #2 is upstream code or documentation.
Shahriyar Rzayev (rzayev-sehriyar) wrote : | #5 |
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/
Actually this comes up in a few places:
xtrabackup: Target instance is assumed as followings.
Also to be clear, I say this shows up when running innobackupex but I believe the typo is in XtraBackup binary, I didn't see anything in innobackupex:
michael@ ubuntu1204: /data/backups/ 2013-07- 05_10-29- 25$ grep followings /usr/bin/ innobackupex | wc -l
0