xtrabackup typo: Temporary instance for recovery is set as followings

[Michael Coburn]

Hi,

When following the status output of innobackupex, one of the lines prints:

xtrabackup: Temporary instance for recovery is set as followings.

I think we should say:

xtrabackup: Temporary instance for recovery is set as following:

followings isn't proper, and I think a colon makes more sense here.

[Michael Coburn (michaelcoburn)]

Actually this comes up in a few places:

xtrabackup: Target instance is assumed as followings.

Also to be clear, I say this shows up when running innobackupex but I believe the typo is in XtraBackup binary, I didn't see anything in innobackupex:

michael@ubuntu1204:/data/backups/2013-07-05_10-29-25$ grep followings /usr/bin/innobackupex | wc -l
0

[Valerii Kravchuk (valerii-kravchuk)]

There are more uses of "followings", all of them are probably wrong:

openxs@debian7:~/bzr/percona-xtrabackup$ grep -rn followings *
Percona-Server/storage/innodb_plugin/log/log0recv.c:3377: "InnoDB: Applying log records was done. Its statistics are followings.\n");
Binary file Percona-Server/storage/innodb_plugin/libinnobase_a-log0recv.o matches
Binary file Percona-Server/storage/innodb_plugin/libinnobase.a matches
Percona-Server/Docs/mysql.info:104313:The followings tips are grouped by category. Some of them can apply in
percona-server-5.1-xtrabackup/patches/innodb_recovery_patches.patch:361:+ "InnoDB: Applying log records was done. Its statistics are followings.\n");
percona-server-5.1-xtrabackup/Percona-Server-5.1.59-rel13.0/storage/innodb_plugin/log/log0recv.c:3377: "InnoDB: Applying log records was done. Its statistics are followings.\n");
Binary file percona-server-5.1-xtrabackup/Percona-Server-5.1.59-rel13.0/storage/innodb_plugin/libinnobase_a-log0recv.o matches
Binary file percona-server-5.1-xtrabackup/Percona-Server-5.1.59-rel13.0/storage/innodb_plugin/libinnobase.a matches
percona-server-5.1-xtrabackup/Percona-Server-5.1.59-rel13.0/Docs/mysql.info:104313:The followings tips are grouped by category. Some of them can apply in
Binary file src/xtrabackup.o matches
Binary file src/xtrabackup matches
src/xtrabackup.cc:1147: msg("xtrabackup: Target instance is assumed as followings.\n");
src/xtrabackup.cc:1150: "followings.\n");
openxs@debian7:~/bzr/percona-xtrabackup$ bzr version-info
revision-id: <email address hidden>
date: 2013-07-01 16:21:20 +0400
build-date: 2013-07-05 18:18:01 +0300
revno: 621
branch-nick: percona-xtrabackup

[Alexey Kopytov (akopytov)]

I try to correct language to the best of my ability when I touch code around those messages. Which means the code that prints those messages is still from early XtraBackup versions. But OK, let's fix it.

[Alexey Kopytov (akopytov)]

The only "followings" occurrence which should be fixed in XtraBackup is

 if (xtrabackup_backup || xtrabackup_stats) {
  msg("xtrabackup: Target instance is assumed as followings.\n");
 } else {
  msg("xtrabackup: Temporary instance for recovery is set as "
      "followings.\n");
 }

Everything else mentioned in comment #2 is upstream code or documentation.