The port lock mechanism in XB test suite does not work
Bug #1194813 reported by
Alexey Kopytov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
Medium
|
Alexey Kopytov | ||
| 2.0 |
Fix Released
|
Medium
|
Alexey Kopytov | ||
| 2.1 |
Fix Released
|
Medium
|
Alexey Kopytov | ||
Bug Description
The following code in the XB test suite which is supposed to lock ports atomically doesn't work as intended:
if ! set -C > $lockfile
then
set +C
# check if the process still exists
...
It should be (set -C; > $lockfile) to check and lock the file atomically.
Related branches
lp:~akopytov/percona-xtrabackup/test-suite-cleanups-2.0
- George Ormond Lorch III (community): Approve (g2)
- Stewart Smith: Pending requested
-
Diff: 1804 lines (+792/-621)16 files modifiedpatches/innodb56.patch (+17/-1)
src/xtrabackup.cc (+6/-14)
test/inc/common.sh (+102/-65)
test/run.sh (+653/-96)
test/subunit.sh (+4/-1)
test/t/bug1085099.sh (+1/-3)
test/t/bug664986.sh (+0/-8)
test/t/bug996493.sh (+0/-4)
test/t/ib_stream_incremental.sh (+1/-1)
test/t/remote_tablespaces.sh (+1/-1)
test/t/undo_tablespaces.sh (+1/-1)
test/t/xb_part_range.sh (+2/-12)
test/t/xb_perm_basic.sh (+0/-2)
test/t/xb_perm_stream.sh (+0/-2)
test/t/xb_stats_datadir.sh (+4/-5)
test/testrun.c (+0/-405)
lp:~akopytov/percona-xtrabackup/test-suite-cleanups-2.1
- George Ormond Lorch III (community): Approve (g2)
- Stewart Smith: Pending requested
-
Diff: 1868 lines (+804/-631)18 files modifiedpatches/innodb56.patch (+17/-1)
src/xtrabackup.cc (+6/-14)
test/inc/common.sh (+104/-68)
test/run.sh (+653/-96)
test/subunit.sh (+4/-1)
test/t/bug1085099.sh (+1/-3)
test/t/bug664986.sh (+0/-8)
test/t/bug996493.sh (+0/-4)
test/t/compact_compressed.sh (+10/-5)
test/t/ib_stream_incremental.sh (+1/-1)
test/t/remote_tablespaces.sh (+1/-1)
test/t/undo_tablespaces.sh (+1/-1)
test/t/xb_encrypt.sh (+0/-2)
test/t/xb_part_range.sh (+2/-12)
test/t/xb_perm_basic.sh (+0/-2)
test/t/xb_perm_stream.sh (+0/-2)
test/t/xb_stats_datadir.sh (+4/-5)
test/testrun.c (+0/-405)
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/