XtraBackup test framework force to use original my.cnf during prepare
Bug #1072695 reported by
Sergei Glushchenko
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
Low
|
Alexey Kopytov | ||
2.0 |
Won't Fix
|
Undecided
|
Unassigned | ||
2.1 |
Won't Fix
|
Undecided
|
Unassigned | ||
2.2 |
Fix Released
|
Low
|
Alexey Kopytov |
Bug Description
innobackupex bash function always invoke innobackupex script with following options:
IB_ARGS=
--socket=
which is incorrect in the case of prepare, when backup-my.cnf should be used (--defaults-file option overrides default backup-my.cnf).
This cause some problems when we want to test backup-my.cnf, or when default my.cnf and backup-my.cnf are not identical, for example when we deal with separate doublewrite file.
Related branches
lp:~akopytov/percona-xtrabackup/read-server-options-with-show-variables
- Sergei Glushchenko (community): Approve
-
Diff: 875 lines (+385/-197)8 files modifiedstorage/innobase/xtrabackup/innobackupex.pl (+182/-136)
storage/innobase/xtrabackup/src/xtrabackup.cc (+106/-48)
storage/innobase/xtrabackup/test/run.sh (+2/-6)
storage/innobase/xtrabackup/test/t/bug1062684.sh (+6/-6)
storage/innobase/xtrabackup/test/t/bug1334062.sh (+24/-0)
storage/innobase/xtrabackup/test/t/bug1343722.sh (+18/-0)
storage/innobase/xtrabackup/test/t/bug766305.sh (+1/-1)
storage/innobase/xtrabackup/test/t/xb_print_param.sh (+46/-0)
Changed in percona-xtrabackup: | |
status: | New → Confirmed |
description: | updated |
summary: |
XtraBackup test framework force to use original my.cnf during prepare - and copy back |
description: | updated |
tags: | added: test |
To post a comment you must log in.
This was fixed in the linked branch by changing innobackupex so that $backup_ dir/backup- my.cnf is always used on --apply-log (even if there's a defaults file specified on the command line).
I don't think there's much use in overriding backup-my.cnf on prepare. In rare cases when someone somewhere may want to do so, one can always replace or edit backup-my.cnf to override some parameters.