Handling of compressed tablespaces with compressed page size == server page size broken
Bug #1044398 reported by
Laurynas Biveinis
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
High
|
Laurynas Biveinis | ||
2.0 |
Fix Released
|
High
|
Laurynas Biveinis | ||
2.1 |
Fix Released
|
High
|
Laurynas Biveinis |
Bug Description
A regression in fix for bug 932623: neither the zip_size nor table compression size is stored in the metadata. Instead, an assumption is made that if page size < UNIV_PAGE_SIZE, then a tablespace is compressed, and if page size == UNIV_PAGE_SIZE, then it's not compressed, e.g. in xtrabackup_
dst_file = xb_delta_
dbname, space_name, info.space_id,
info.page_size == UNIV_PAGE_SIZE ? 0 : info.page_size,
dst_path, sizeof(dst_path), &success);
This assumption breaks for compressed tables with page size == UNIV_PAGE_SIZE, and the actual zip_size should be stored in metadata in addition to page_size.
Related branches
lp:~laurynas-biveinis/percona-xtrabackup/bug1044398-2.0
On hold
for merging
into
lp:percona-xtrabackup/2.0
- Alexey Kopytov (community): Needs Fixing
-
Diff: 146 lines (+57/-12)2 files modifiedsrc/xtrabackup.c (+20/-12)
test/t/bug1044398.sh (+37/-0)
lp:~laurynas-biveinis/percona-xtrabackup/bug1044398-2.1
On hold
for merging
into
lp:percona-xtrabackup/2.1
- Alexey Kopytov (community): Needs Fixing
-
Diff: 124 lines (+53/-6)4 files modifiedsrc/write_filt.c (+1/-0)
src/xtrabackup.c (+12/-4)
src/xtrabackup.h (+3/-2)
test/t/bug1044398.sh (+37/-0)
lp:~laurynas-biveinis/percona-xtrabackup/bug1049174-2.0
- Alexey Kopytov (community): Approve
-
Diff: 304 lines (+139/-56)1 file modifiedsrc/xtrabackup.c (+139/-56)
lp:~laurynas-biveinis/percona-xtrabackup/bug1049174-2.1
- Alexey Kopytov (community): Approve
-
Diff: 370 lines (+181/-61)5 files modifiedsrc/innodb_int.c (+116/-0)
src/innodb_int.h (+35/-1)
src/write_filt.c (+2/-17)
src/xtrabackup.c (+25/-41)
src/xtrabackup.h (+3/-2)
To post a comment you must log in.
There is no user impact in 2.0.2. It only starts breaking things for other work in progress.