Handling of compressed tablespaces with compressed page size == server page size broken

Bug #1044398 reported by Laurynas Biveinis on 2012-08-31
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup
High
Laurynas Biveinis
2.0
High
Laurynas Biveinis
2.1
High
Laurynas Biveinis

Bug Description

A regression in fix for bug 932623: neither the zip_size nor table compression size is stored in the metadata. Instead, an assumption is made that if page size < UNIV_PAGE_SIZE, then a tablespace is compressed, and if page size == UNIV_PAGE_SIZE, then it's not compressed, e.g. in xtrabackup_apply_delta():

 dst_file = xb_delta_open_matching_space(
   dbname, space_name, info.space_id,
   info.page_size == UNIV_PAGE_SIZE ? 0 : info.page_size,
   dst_path, sizeof(dst_path), &success);

This assumption breaks for compressed tables with page size == UNIV_PAGE_SIZE, and the actual zip_size should be stored in metadata in addition to page_size.

Related branches

lp:~laurynas-biveinis/percona-xtrabackup/bug1044398-2.0
Alexey Kopytov: Needs Fixing on 2012-09-07
lp:~laurynas-biveinis/percona-xtrabackup/bug1044398-2.1
Alexey Kopytov: Needs Fixing on 2012-09-07
lp:~laurynas-biveinis/percona-xtrabackup/bug1049174-2.0
Merged into lp:percona-xtrabackup/2.0 at revision 469
Alexey Kopytov: Approve on 2012-09-19
lp:~laurynas-biveinis/percona-xtrabackup/bug1049174-2.1
Merged into lp:percona-xtrabackup/2.1 at revision 436
Alexey Kopytov: Approve on 2012-09-19

There is no user impact in 2.0.2. It only starts breaking things for other work in progress.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers