Incremental backups may take up to 5x more space after the fix for bug #1022562
Bug #1043762 reported by
Alexey Kopytov
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
High
|
Laurynas Biveinis | ||
2.0 |
Fix Released
|
High
|
Laurynas Biveinis | ||
2.1 |
Fix Released
|
High
|
Laurynas Biveinis |
Bug Description
Fix for bug #1022562 introduced a regression that may potentially lead to a 5x increase in disk space occupied by incremental backups.
The problem is that after the fix for bug #1022562 incremental backups take 64 KB more per _every_ table, even if it has not been modified. We have customers with 100,000+ tables (see bug #950334). A simple calculation shows their incremental backups would now take 6+ GB more, even if there have been absolutely no data updates.
I think the fix should be re-implemented to properly initialize the 1st page when a new tablespace has to be created on prepare. It's quite easy to do, we can reuse the code from fil_create_
Related branches
lp:~laurynas-biveinis/percona-xtrabackup/bug1043762-2.0
On hold
for merging
into
lp:percona-xtrabackup/2.0
- Percona core: Pending requested
-
Diff: 166 lines (+103/-27)1 file modifiedsrc/xtrabackup.c (+103/-27)
lp:~laurynas-biveinis/percona-xtrabackup/bug1043762-2.1
On hold
for merging
into
lp:percona-xtrabackup/2.1
- Percona core: Pending requested
-
Diff: 179 lines (+99/-33)2 files modifiedsrc/write_filt.c (+1/-17)
src/xtrabackup.c (+98/-16)
lp:~laurynas-biveinis/percona-xtrabackup/bug1049174-2.0
- Alexey Kopytov (community): Approve
-
Diff: 304 lines (+139/-56)1 file modifiedsrc/xtrabackup.c (+139/-56)
lp:~laurynas-biveinis/percona-xtrabackup/bug1049174-2.1
- Alexey Kopytov (community): Approve
-
Diff: 370 lines (+181/-61)5 files modifiedsrc/innodb_int.c (+116/-0)
src/innodb_int.h (+35/-1)
src/write_filt.c (+2/-17)
src/xtrabackup.c (+25/-41)
src/xtrabackup.h (+3/-2)
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/ /jira.percona. com/browse/ PXB-339