pt-query-digest doesn't distill INSERT/REPLACE without INTO correctly
Bug #984053 reported by
Baron Schwartz
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Daniel Nichter | ||
| 2.1 |
Won't Fix
|
Undecided
|
Unassigned | ||
| 2.2 |
Fix Released
|
Medium
|
Daniel Nichter | ||
Bug Description
A user reported the following:
insert ignore_bar (id) values (4029731);
Distills to INSERT. The attached patch is claimed to solve this.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-pqd-distill-bugs
- Daniel Nichter: Approve
-
Diff: 1655 lines (+779/-514)18 files modifiedbin/pt-query-digest (+559/-490)
lib/HTTP/Micro.pm (+1/-1)
lib/QueryParser.pm (+16/-4)
lib/QueryRewriter.pm (+10/-0)
lib/VersionCheck.pm (+2/-2)
t/lib/QueryParser.t (+6/-0)
t/lib/QueryRewriter.t (+28/-0)
t/lib/samples/slowlogs/slow051.txt (+2/-2)
t/lib/samples/slowlogs/slow058.txt (+24/-0)
t/pt-query-digest/binlog_analyses.t (+2/-2)
t/pt-query-digest/daemon.t (+2/-2)
t/pt-query-digest/json.t (+1/-1)
t/pt-query-digest/samples/binlog002.txt (+4/-1)
t/pt-query-digest/samples/empty_report.txt (+2/-0)
t/pt-query-digest/samples/slow051.txt (+5/-5)
t/pt-query-digest/samples/slow058.txt (+94/-0)
t/pt-query-digest/slowlog_analyses.t (+20/-3)
util/update-modules (+1/-1)
Revision history for this message
| Baron Schwartz (baron-xaprb) wrote | #1 |
Revision history for this message
| Brian Fraser (fraserbn) wrote | #2 |
Revision history for this message
| Baron Schwartz (baron-xaprb) wrote | #3 |
| Changed in percona-toolkit: | |
| milestone: | none → 2.1.8 |
| Changed in percona-toolkit: | |
| importance: | Medium → Undecided |
| milestone: | 2.1.8 → none |
| Changed in percona-toolkit: | |
| milestone: | none → 2.2.5 |
| importance: | Undecided → Medium |
| summary: |
- Distill doesn't handle INSERT/REPLACE without INTO + pt-query-digest doesn't distill INSERT/REPLACE without INTO correctly |
Revision history for this message
| Daniel Nichter (daniel-nichter) wrote | #4 |
| tags: | added: pt-query-digest |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #5 |
To post a comment you must log in.
Hey Baron.
Any clue who provided the patch? The bug report seems to imply that it wasn't you. I'd like to apply it, but it feels icky without proper attribution.