Percona Toolkit

pt-stalk documentation for .conf file is wrong

Reported by Frederic Descamps on 2011-10-23
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Percona Toolkit
Undecided
Unassigned
1.0
Medium
Unassigned
2.0
Undecided
Unassigned

Bug Description

In the documentation it's mention that if the file pt-stalk.conf exists in the current working directory, then “ENVIRONMENT” variables are imported from it. But in fact if pt-stalk is in the path, it won't use the config file in the current working dir but in the directory where the command is.

Frederic Descamps (lefred) wrote :

patch to solve this

description: updated

I believe this is a duplicate issue.

What we need to do is add configuration capabilities to all of the
tools inherited from Aspersa, to match those of the tools from Maatkit.
I don't know why the documentation mentioned the cwd, because when I
wrote the code originally it was designed to be $0.conf, which is
basically an idea I copied from the Cacti templates. However this is
not the best thing; it should be
~/.tool.conf, /etc/percona-toolkit/tool.conf, and so on.

summary: - pt-stalk If the file pt-stalk.conf does not use ptstalk.conf in the
- current working directory
+ pt-stalk may not read .conf file in the current working directory
Changed in percona-toolkit:
importance: Undecided → Medium
milestone: none → 2.0-beta2
tags: added: conf pt-stalk

It's not supposed to read the file in the cwd, it's supposed to read $0.conf. The documentation is wrong, not the tool. Let's not change the code until we get proper configuration files for the bash tools.

summary: - pt-stalk may not read .conf file in the current working directory
+ pt-stalk documentation for .conf file is wrong
Daniel Nichter (daniel-nichter) wrote :

pt-stalk is rewritten in 2.0 which makes this bug invalid for that series.

Changed in percona-toolkit:
milestone: 2.0-beta2 → none
tags: added: docs
removed: conf
Brian Fraser (fraserbn) wrote :

Since we're no longer making patches for the 1.0 series, I'm marking this bug as Won't Fix there.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers