Invalid --max-load and --critical-load crash pt-online-schema-change

[Will Gunty]

If --max-load and/or --critical-load are not in the correct format, the tool "crashes" without a good error message:

wgunty@dba1001:~$ pt-online-schema-change --max-load 1000 - --host HOST --user=USER --password='PASS!' --alter "ALTER HERE" D=db,t=table --execute

Use of uninitialized value in multiplication (*) at /usr/bin/pt-online-schema-change line 3735.

Expected behavior should error and state that an invalid format has been entered.

[Daniel Nichter (daniel-nichter)]

See also bug 972026.

[Daniel Nichter (daniel-nichter)]

Now with early error checking and nice error messages:

--max-load 100
Errors in command-line arguments:
  * Invalid --max-load: 100 is not a variable name

--max-load foo=bar
Errors in command-line arguments:
  * Invalid --max-load: The value for foo must be a number

--max-load foo=100
Error checking --max-load or --critial-load: Variable foo does not exist or its value is undefined. Check that the variables specified for --max-load and --critical-load are spelled correctly and exist in SHOW GLOBAL STATUS. Current values for these options are:
  --max-load foo=100
  --critial-load Threads_running=50

[Daniel Nichter (daniel-nichter)]

Fixed in pt-table-checksum too (although it only has --max-load).

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-530