Percona Toolkit moved to https://jira.percona.com/projects/PT

Wrong advise regarding IP-addresses

Bug #983191 reported by Miguel Trias
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Won't Fix
Undecided
Unassigned

Bug Description

Advise for query:

SELECT id,UNIX_TIMESTAMP(some_column)
FROM some_table WHERE ip=INET_ATON('111.111.111.111')

incorrectly suggests that IP-numbers should be stored as integers, which is already the case.
The tools suggest conversion to integer by use of INET_ATON(), which is already present in the query.

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

The new SQLParser.pm should make this easy to fix because it actually parses functions whereas older versions of the module did not.

tags: added: pt-query-advisor query-rule
Changed in percona-toolkit:
status: New → Confirmed
Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

We decided to remove pt-query-advisor in Percona Toolkit 2.2 and refocus our efforts on the online version of this tool (https://tools.percona.com/query-advisor). This issue has been moved to https://github.com/percona/query-advisor/issues/23.

Changed in percona-toolkit:
status: Confirmed → Won't Fix
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-959

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.