Wrong advise regarding IP-addresses

Reported by Miguel Trias on 2012-04-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit
Undecided
Unassigned

Bug Description

Advise for query:

SELECT id,UNIX_TIMESTAMP(some_column)
FROM some_table WHERE ip=INET_ATON('111.111.111.111')

incorrectly suggests that IP-numbers should be stored as integers, which is already the case.
The tools suggest conversion to integer by use of INET_ATON(), which is already present in the query.

Daniel Nichter (daniel-nichter) wrote :

The new SQLParser.pm should make this easy to fix because it actually parses functions whereas older versions of the module did not.

tags: added: pt-query-advisor query-rule
Changed in percona-toolkit:
status: New → Confirmed
Daniel Nichter (daniel-nichter) wrote :

We decided to remove pt-query-advisor in Percona Toolkit 2.2 and refocus our efforts on the online version of this tool (https://tools.percona.com/query-advisor). This issue has been moved to https://github.com/percona/query-advisor/issues/23.

Changed in percona-toolkit:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers