pt-variable-advisor does not consider innodb-plugin

[Giovanni Bechis]

If innodb-plugin is enabled in MySQL 5.1.x, pt-variable-advisor give a note abot the variable "innodb_max_dirty_pages_pct" too low.
If innodb-plugin is enabled this variable has a different default than with internal innodb storage.

http://dev.mysql.com/doc/refman/5.1/en/innodb-parameters.html#sysvar_innodb_max_dirty_pages_pct

Maybe other parameters have different defaults too.

---------------------
$ pt-variable-advisor h=host,u=root --ask-pass
Enter password:
# NOTE innodb_max_dirty_pages_pct: The innodb_max_dirty_pages_pct is lower than the default.

On server I am using MySQL 5.1.61

  Giovanni

[Baron Schwartz (baron-xaprb)]

Thank you for the bug report. Indeed, the default did change with the plugin, and what we should do is warn if the setting is non-default. We can avoid a lot of complex logic by just testing whether the value is equal to the default in the old or new version, regardless of the actual version running.

[Giovanni Bechis (bigionews)]

On 03/08/12 18:39, Baron Schwartz wrote:
> Thank you for the bug report. Indeed, the default did change with the
> plugin, and what we should do is warn if the setting is non-default. We
> can avoid a lot of complex logic by just testing whether the value is
> equal to the default in the old or new version, regardless of the actual
> version running.
>
It could be fine but we should handle different default parameters in
different MySQL versions too.
Maybe something like this could be used:
if ($mysql_ver -eq 5.0) {
 %default_var = ('var1' => 'value1','var2' => 'value2');
} elseif....

 Giovanni

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-494