pt-table-checksum has ambiguous exit status
Bug #944051 reported by
Marco
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
High
|
Daniel Nichter |
Bug Description
From pt-table-checksum manual: "The tool’s exit status is nonzero if any differences are found, or if any warnings or errors occur."
It would be nice to distinguish, with different status codes, errors (e.g. table skipped) from diffs (different tables checksum). Indeed errors may occur temporarily and don't break replicas integrity, while diffs do.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-ptc-exit-status-bug-944051
- Daniel Nichter: Approve
-
Diff: 799 lines (+332/-189)6 files modifiedbin/pt-table-checksum (+297/-170)
lib/PerconaTest.pm (+4/-0)
t/pt-table-checksum/basics.t (+4/-4)
t/pt-table-checksum/chunk_index.t (+1/-1)
t/pt-table-checksum/error_handling.t (+13/-5)
t/pt-table-checksum/standard_options.t (+13/-9)
tags: | added: ambiguity pt-table-checksum |
Changed in percona-toolkit: | |
importance: | Undecided → Wishlist |
Changed in percona-toolkit: | |
status: | New → Triaged |
Changed in percona-toolkit: | |
milestone: | none → 2.2.5 |
assignee: | nobody → Daniel Nichter (daniel-nichter) |
importance: | Wishlist → High |
status: | Triaged → In Progress |
summary: |
- pt-table-checksum: exit status ambiguous + pt-table-checksum has ambiguous exit status |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
status: | Fix Committed → In Progress |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
pt-table-sync has the following:
STATUS MEANING ======= ======= ======= ======= ======= ======= ======
====== =======
0 Success.
1 Internal error.
2 At least one table differed on the destination.
3 Combination of 1 and 2.
I'd love to see something similar on pt-table-checksum along the lines of:
STATUS MEANING ======= ======= ======= ======= ======= ======= ======
====== =======
0 Success.
1 Could not start due to PID
2 Internal error.
3 At least one table differed on the destination.