pt-slave-restart CHANGE MASTER query causes error
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Daniel Nichter |
Bug Description
This is very low priority I guess but had me confused for a few minutes.
I've got a crashed replication and thought 'what the hell, lets see what pt-slave-restart does on it'.
relevant excerpt of SHOW SLAVE STATUS:
This is the result:
root@miho:
2012-02-15T10:50:28 mysqld-
DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''56390410'' at line 1 [for Statement "CHANGE MASTER TO MASTER_LOG_FILE=?, MASTER_LOG_POS=?" with ParamValues: 0='mysql-
"Huh? What's wrong with that query then?"
I understand why it doesn't work, and that it can't work, but perhaps there should be a list of errors that pt-slave-restart should refuse to run on?
Related branches
- Daniel Nichter: Approve
-
Diff: 105 lines (+19/-23)2 files modifiedbin/pt-slave-restart (+12/-15)
t/pt-slave-restart/pt-slave-restart.t (+7/-8)
tags: | added: pt-slave-restart |
tags: | added: crash wrong-sql |
Changed in percona-toolkit: | |
status: | New → Confirmed |
Changed in percona-toolkit: | |
milestone: | none → 2.1.8 |
importance: | Undecided → Medium |
Changed in percona-toolkit: | |
assignee: | nobody → Daniel Nichter (daniel-nichter) |
summary: |
- pt-slave-restart slightly confusing error if slave crashed + pt-slave-restart CHANGE MASTER query causes error |
Changed in percona-toolkit: | |
status: | Confirmed → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
Erm. I think I should read the documentation before reporting. Sorry about that...