pt-query-digest incorrect query_review_history table definition

[Gavin Towey]

pt-query-digest --version
pt-query-digest 1.0.1

The table definition for query_review_history has the following columns in it:

 Disk_tmp_table_cnt FLOAT,
  Disk_tmp_table_sum FLOAT,

  Disk_filesort_cnt FLOAT,
  Disk_filesort_sum FLOAT,

However in percona mysql 5.5, the attributes in the slow query log look like this:
# QC_Hit: No Full_scan: No Full_join: No Tmp_table: No Tmp_table_on_disk: No
# Filesort: No Filesort_on_disk: No Merge_passes: 0

This difference in column name seems to cause the data not to be collected when you save digest results to a table. The correct column names should be:
    Tmp_table_on_disk_cnt FLOAT,
    Tmp_table_on_disk_sum FLOAT,
    Filesort_on_disk_cnt FLOAT,
    Filesort_on_disk_sum FLOAT,

Attached find patch to fix this.

[Brian Fraser (fraserbn)]

Looks like this one fell through the cracks, then resurfaced as https://bugs.launchpad.net/percona-toolkit/+bug/963225

Gavin, thank you for the report and the patch! Apologies that it didn't get the attention it deserved; The good news is that this will all be fixed in the upcoming release of the toolkit.

I'm marking this ticket as invalid, as the other one has some extra information, but linking the other report here for reference.

[Gavin Towey (gtowey)]

Awesome, thanks for fixing this!