pt-query-advisor parses text within comments

Bug #821695 reported by Daniel Nichter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Won't Fix
Low
Brian Fraser

Bug Description

Imported from http://code.google.com/p/maatkit/issues/detail?id=1250

Quoting the original:

While checking for rule 'STA.001', the tool seems to blindly scan the query for the pattern '!=', and reports it even if it appears in comments, thus incorrectly reporting that the query has a non standard operation.

e.g. A STA.001 note is generated for the query:
/* use <> instead of != */ SELECT a.col FROM table as a WHERE a.col2 = 20

Brian Fraser (fraserbn)
Changed in percona-toolkit:
status: New → Confirmed
Brian Fraser (fraserbn)
Changed in percona-toolkit:
assignee: nobody → Brian Fraser (fraserbn)
status: Confirmed → In Progress
Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

pt-query-advisor was removed in 2.2. Use pt-query-advisor 2.1 or the online tool: https://tools.percona.com/query-advisor.

This issue has been moved to https://github.com/percona/query-advisor/issues/4.

Changed in percona-toolkit:
status: In Progress → Won't Fix
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-746

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.