pt-online-schema-change slave-user and slave-password ignored when recursion-method is dsn

[Iwo]

Options --slave-user and --slave-password of pt-online-schema-change are ignored when --recursion-method is set to dsn.

Step to reproduce:

$ PTDEBUG=1 pt-online-schema-change --recursion-method dsn=t=percona.dsns --execute D=test,t=test,h=127.0.0.1,P=20594 --slave-user dupa123 --slave-pass test321 --user=root --password=msandbox --alter "ENGINE=InnoDB"

[...]

# MasterSlave:4845 7838 SELECT dsn FROM `percona`.`dsns` ORDER BY id
# MasterSlave:4850 7838 DSN from DSN table: h=127.0.0.1,P=20595
# DSNParser:2241 7838 DSN string made from options: u=root,p=msandbox

The workaround is to define slave user and slave password directly in dsns.

Tested against pt-online-schema-change 3.0.4.

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-1460