pt-stalk not honoring all configs listed with --config

Bug #1575373 reported by bar down
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
New
Undecided
Unassigned

Bug Description

Are we sure this pt-stalk --config command actually parses correctly still?

Aside from the above mention of --config= not working, it seems things are still not parsed correctly (or honored) when used without the = sign.

For instance when using multiple configs, it seems that the LAST config is the only one honored:

pt-stalk --config ./deadlocks.conf,./longquery.conf,./highcnx.conf --dest=/var/lib/mysql/pt-stalk --log=/var/log/mysql/pt-stalk/pt-stalk.log --sleep=30 --defaults-file=/etc/percona-toolkit.conf

output:
2016_04_25_15_51_59 Starting /usr/bin/pt-stalk --function=status --variable=Threads_running --threshold=100 --match= --cycles=5 --interval=1 --iterations= --run-time=30 --sleep=30 --dest=/var/lib/mysql/pt-stalk --prefix= --notify-by-email= --log=/var/log/mysql/pt-stalk/pt-stalk.log --pid=/var/run/pt-stalk.pid --plugin=

In this example, my longquery.conf is not triggering, but if I put it as the last argument in the list of configs, it does:
[root@testl1 configs]# pt-stalk --config ./deadlocks.conf,./highcnx.conf,./longquery.conf --dest=/var/lib/mysql/pt-stalk --log=/var/log/mysql/pt-stalk/pt-stalk.log --sleep=30 --defaults-file=/etc/percona-toolkit.conf
2016_04_25_15_52_46 Starting /usr/bin/pt-stalk --function=/usr/local/bin/mysql/pt-stalk/functions/longquery.sh --variable=Long_Query --threshold=0 --match= --cycles=5 --interval=1 --iterations= --run-time=30 --sleep=30 --dest=/var/lib/mysql/pt-stalk --prefix= --notify-by-email= --log=/var/log/mysql/pt-stalk/pt-stalk.log --pid=/var/run/pt-stalk.pid --plugin=
2016_04_25_15_53_52 Check results: /usr/local/bin/mysql/pt-stalk/functions/longquery.sh(Long_Query)=1, matched=yes, cycles_true=1
2016_04_25_15_53_53 Check results: /usr/local/bin/mysql/pt-stalk/functions/longquery.sh(Long_Query)=1, matched=yes, cycles_true=2
2016_04_25_15_53_54 Check results: /usr/local/bin/mysql/pt-stalk/functions/longquery.sh(Long_Query)=1, matched=yes, cycles_true=3
2016_04_25_15_53_55 Check results: /usr/local/bin/mysql/pt-stalk/functions/longquery.sh(Long_Query)=1, matched=yes, cycles_true=4
2016_04_25_15_53_56 Check results: /usr/local/bin/mysql/pt-stalk/functions/longquery.sh(Long_Query)=1, matched=yes, cycles_true=5
2016_04_25_15_53_56 Collect 1 triggered
2016_04_25_15_53_56 Collect 1 PID 50385
2016_04_25_15_53_56 Collect 1 done
2016_04_25_15_53_56 Sleeping 30 seconds after collect
;;

Version:
pt-stalk 3.0.4

Revision history for this message
bar down (bardown) wrote :

Same results with version pt-stalk 2.2.17

bar down (bardown)
information type: Public → Private
summary: - pt-stalk not honoring all configs listed with --config
+ stlk cnf
bar down (bardown)
summary: - stlk cnf
+ pt-stalk not honoring all configs listed with --config
bar down (bardown)
information type: Private → Public
Revision history for this message
Sveta Smirnova (svetasmirnova) wrote :

Thank you for the report.

I cannot repeat this behavior with current version 2.2.19 Please try this version and if bug still exists provide configuration files you use.

Changed in percona-toolkit:
status: New → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for Percona Toolkit because there has been no activity for 60 days.]

Changed in percona-toolkit:
status: Incomplete → Expired
Revision history for this message
bar down (bardown) wrote :

Sveta, can you paste me the CLI you are using? I'd be more curious to see a working example?

Changed in percona-toolkit:
status: Expired → In Progress
description: updated
Revision history for this message
bar down (bardown) wrote :

I should mention that I've now tested this on the latest version of pt-stalk with the same exact behavior. Version: pt-stalk 3.0.4

No changes in behavior. If anyone uses the --config command correctly or has some way of monitoring multiple triggers at the same time I would love to see an example or sample output!

description: updated
description: updated
Revision history for this message
bar down (bardown) wrote :

Marking new as I've updated the version to the latest, still without luck.

Changed in percona-toolkit:
status: In Progress → New
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-1342

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.