pt-mysql-summary is missing the "--ask-pass" option

Bug #1455486 reported by Jean Weisbuch on 2015-05-15
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Fix Released
Medium
Frank Cizmich

Bug Description

All the other Percona Toolkit tools that are connecting to a MySQL server have the "--ask-pass" option which is a good practice when the password for the requested user is not available in "~/.my.cnf".

It probably hasnt been implemented yet as its the only shell script that does connect to a MySQL server while the others are in Perl so there is no direct copy/paste to do but it shouldnt be an issue to implement, I could do it if required.

Changed in percona-toolkit:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Frank Cizmich (frank-cizmich)
milestone: none → 2.3.1
Frank Cizmich (frank-cizmich) wrote :

Hello Jean,

Thanks for pointing this out!
Will be available in next release.
I've attached a patch. Check it out if you have time and see if it fits your needs.
There are shorter ways to do this but this one is supposedly POSIX compliant.

Frank Cizmich (frank-cizmich) wrote :

Jean,

Please ignore previous patch and use this one.

tags: added: pt-mysql-summary
Jean Weisbuch (m-jea0-p) wrote :

The fix seems to be correct but i would add quotes around the $GIVEN_PASS variable at line 500 to avoid problems if the password has spaces or other control characters (and do the same at line 502).

Changed in percona-toolkit:
status: Fix Committed → Fix Released

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-684

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers