Recursive Code on On Exception from pt-osc

Bug #1453334 reported by Jervin R
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Fix Committed
Medium
Frank Cizmich

Bug Description

1) Coredump when ALTER TABLE fails. The issue is that it will cause endless recursion. See patch file to fix the issue. The issue was introduced in 2.1
--- pt-online-schema-change.orig 2015-04-16 10:54:56.269371525 -0700
+++ pt-online-schema-change 2015-04-16 10:55:58.003839279 -0700
@@ -8575,9 +8575,9 @@
);

local $SIG{__DIE__} = sub {
+ undef $cleanup;
return if $EXCEPTIONS_BEING_CAUGHT;
local $EVAL_ERROR = $_[0];
- undef $cleanup;
die @_;
};

Revision history for this message
Jervin R (revin) wrote :

Credits to bug and path to customer on tagged issue.

tags: added: i53065
Revision history for this message
Frank Cizmich (frank-cizmich) wrote :

This is a duplicate of https://bugs.launchpad.net/percona-toolkit/+bug/1446928
Although the title and summary description in this one are more accurate.
There's also a patch on the other report that works and uses a different approach.

Revision history for this message
Frank Cizmich (frank-cizmich) wrote :

Let's keep this one as the reference issue report because it's more accurate.

tags: added: pt-online-schema-change
Changed in percona-toolkit:
status: New → Fix Committed
milestone: none → 2.3.1
Revision history for this message
Frank Cizmich (frank-cizmich) wrote :

Including same patch as other report for convenience.

Changed in percona-toolkit:
importance: Undecided → High
assignee: nobody → Frank Cizmich (frank-cizmich)
importance: High → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.