pt-upgrade fails to aggregate queries based on fingerprint
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
High
|
Frank Cizmich |
Bug Description
Running pt-upgrade against a log with many identical (or similar) queries produces repeated sections with the same fingerprint.
Also, reported number of row diffs is wrong:
"Reporting class because there are 1000 row diffs."
PT 2.2.13
sample command:
perl pt-upgrade --type rawlog host1 host2 /tmp/raw.log
sample output (summarized for brevity)
#######
# Query class E3B134C63BD31D85
#######
Reporting class because there are 1000 row diffs.
Total queries 3
Unique queries 3
Discarded queries 0
select * from test.test;
##
## Row diffs: 3
##
-- 1.
@ row 1
< 8771687,B
> 15269,NULL
.....
#######
# Query class E3B134C63BD31D85
#######
Reporting class because there are 1000 row diffs.
Total queries 4
Unique queries 4
Discarded queries 0
select * from test.test;
##
## Row diffs: 3
##
-- 1.
@ row 1
< 8771687,B
> 15269,NULL
....
#######
# Query class E3B134C63BD31D85
#######
Reporting class because there are 1000 row diffs.
Total queries 5
Unique queries 5
Discarded queries 0
select * from test.test;
##
## Row diffs: 3
##
etc
.....
..
Related branches
- Daniel Nichter: Approve
-
Diff: 237 lines (+112/-16)5 files modifiedbin/pt-upgrade (+13/-8)
lib/UpgradeResults.pm (+13/-8)
t/pt-upgrade/samples/008/conf (+2/-0)
t/pt-upgrade/samples/008/fingerprint-grouping-and-max-examples-issue-1421405.log (+9/-0)
t/pt-upgrade/samples/008/fingerprint-grouping-and-max-examples-issue-1421405.txt (+75/-0)
description: | updated |
tags: | added: pt-upgrade |
Changed in percona-toolkit: | |
importance: | Undecided → High |
status: | New → In Progress |
assignee: | nobody → Frank Cizmich (frank-cizmich) |
milestone: | none → 2.2.14 |
description: | updated |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
Fixed by skipping already reported classes. Also fixed erroneous number of diffs report.