Plugin hooks for pt-table-checksum need to be expanded

Bug #1417214 reported by Joe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Confirmed
Undecided
Unassigned

Bug Description

Now that there is support for plugins with pt-table-checksum, I tried to write a plugin to override arguments per table (See Bug #930300 for more details). The arguments that I wanted to override are as follows.

check-plan chunk-size chunk-size-limit columns ignore-columns where

Needless to say, I was unsuccessful. The current implementation of plugins is just not expansive enough to facilitate this ability.

It would be nice if the plugin interface was expanded to allow for overriding arguments per table. One way to do this might be to add the applicable command arguments to the table object and then the tool would use these when checksumming the table. The before_checksum_table hook has access to the table object and so then would be able to change these arguments before the checksum was done.

It also would be nice for a plugin to be able to add arguments to pt-table-checksum. In the above case, I would like to add the argument --arg-table through the plugin interface.

Revision history for this message
Valerii Kravchuk (valerii-kravchuk) wrote :

This is easy to confirm based on code review.

Changed in percona-toolkit:
status: New → Confirmed
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-1263

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.