Not all scripts recognize no-version-check
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
High
|
Frank Cizmich |
Bug Description
Some of the percona toolkit scripts have an automatic version check at the start of the script. This is considered a security risk due to external web access. I have created a global config, /etc/percona-
It seems that not all tools recognize this option and, pt-show-grants in particular, aborts and won't run. This defeats the purpose of a "global toolkit" configuration file.
The following pt scripts don't appear to have any code related to version checking. Please add the relevant code to these scripts, or add code to silently ignore this and other "global" options.
pt-align
pt-fifo-split
pt-fingerprint
pt-ioprofile
pt-mext
pt-mysql-summary
pt-pmp
pt-show-grants
pt-sift
pt-slave-find
pt-stalk
pt-summary
pt-table-usage
pt-visual-explain
Related branches
- Daniel Nichter: Needs Fixing
-
Diff: 402 lines (+141/-27)17 files modifiedbin/pt-align (+8/-0)
bin/pt-fifo-split (+8/-0)
bin/pt-fingerprint (+8/-0)
bin/pt-ioprofile (+4/-1)
bin/pt-mext (+29/-23)
bin/pt-mysql-summary (+2/-0)
bin/pt-pmp (+4/-1)
bin/pt-show-grants (+8/-0)
bin/pt-sift (+4/-1)
bin/pt-slave-find (+8/-0)
bin/pt-stalk (+4/-1)
bin/pt-summary (+2/-0)
bin/pt-table-usage (+8/-0)
bin/pt-visual-explain (+8/-0)
lib/OptionParser.pm (+10/-0)
lib/bash/parse_options.sh (+3/-0)
t/lib/OptionParser.t (+23/-0)
Changed in percona-toolkit: | |
assignee: | nobody → Frank Cizmich (frank-cizmich) |
importance: | Undecided → High |
Changed in percona-toolkit: | |
status: | Confirmed → In Progress |
Changed in percona-toolkit: | |
milestone: | none → 2.2.12 |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
This is easy to confirm with above mentioned tools from Percona Toolkit 2.2.10. They produce somewhat different error messages for no-version-check