Not all scripts recognize no-version-check

Bug #1361293 reported by Matthew B
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Fix Released
High
Frank Cizmich

Bug Description

Some of the percona toolkit scripts have an automatic version check at the start of the script. This is considered a security risk due to external web access. I have created a global config, /etc/percona-toolkit/percona-toolkit.conf with the single line "no-version-check"

It seems that not all tools recognize this option and, pt-show-grants in particular, aborts and won't run. This defeats the purpose of a "global toolkit" configuration file.

The following pt scripts don't appear to have any code related to version checking. Please add the relevant code to these scripts, or add code to silently ignore this and other "global" options.

pt-align
pt-fifo-split
pt-fingerprint
pt-ioprofile
pt-mext
pt-mysql-summary
pt-pmp
pt-show-grants
pt-sift
pt-slave-find
pt-stalk
pt-summary
pt-table-usage
pt-visual-explain

Related branches

Revision history for this message
Valerii Kravchuk (valerii-kravchuk) wrote :

This is easy to confirm with above mentioned tools from Percona Toolkit 2.2.10. They produce somewhat different error messages for no-version-check

Changed in percona-toolkit:
status: New → Confirmed
Changed in percona-toolkit:
assignee: nobody → Frank Cizmich (frank-cizmich)
importance: Undecided → High
Changed in percona-toolkit:
status: Confirmed → In Progress
Changed in percona-toolkit:
milestone: none → 2.2.12
Changed in percona-toolkit:
status: In Progress → Fix Committed
Revision history for this message
Frank Cizmich (frank-cizmich) wrote :

Changed all tools that don't support the option to silently ignore it if it is provided via config file.

Changed in percona-toolkit:
status: Fix Committed → Fix Released
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-377

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers