pt-osc unclean abort on critical load

[Rares Mirica]

Running pt-osc with --critical-load triggers an unclean exit upon hitting the critical condition, output attached.

Note: pt-osc does the right thing and leaves the DB in a consistent state (dropping triggers and the new table) BUT it confuses any tool that tries to parse it's output, even human eyes...

[Nilnandan Joshi (nilnandan-joshi)]

Have tried to verify with latest version but getting different result. Can you provide the exact version of pt-osc and MySQL /Percona server ?

nilnandan@nilnandan-Dell-XPS:~$ pt-online-schema-change --version
pt-online-schema-change 2.2.10
nilnandan@nilnandan-Dell-XPS:~$ pt-online-schema-change --alter "add column name2 varchar(16)" h=127.0.0.1,u=root,p=root,D=nil,t=test --critical-load Threads_running=1 --execute
No slaves found. See --recursion-method if host nilnandan-Dell-XPS has slaves.
Not checking slave lag because no slaves were found and --check-slave-lag was not specified.
Operation, tries, wait:
  copy_rows, 10, 0.25
  create_triggers, 10, 1
  drop_triggers, 10, 1
  swap_tables, 10, 1
  update_foreign_keys, 10, 1
Altering `nil`.`test`...
Creating new table...
Created new table nil._test_new OK.
Altering new table...
Altered `nil`.`_test_new` OK.
2014-08-26T10:58:15 Dropping new table...
2014-08-26T10:58:15 Dropped new table OK.
`nil`.`test` was not altered.
Killed
nilnandan@nilnandan-Dell-XPS:~$

[Nilnandan Joshi (nilnandan-joshi)]

Was able to reproduce with 2.2.9. With 2.2.10 might be this is the issue. https://bugs.launchpad.net/percona-toolkit/+bug/1361537

root@localhost# pt-online-schema-change --alter "add column name2 varchar(16)" h=localhost,u=root,p=root,D=test,t=test --critical-load Threads_running=1 --execute
No slaves found. See --recursion-method if host deb-pxc56-1 has slaves.
Not checking slave lag because no slaves were found and --check-slave-lag was not specified.
Operation, tries, wait:
  copy_rows, 10, 0.25
  create_triggers, 10, 1
  drop_triggers, 10, 1
  swap_tables, 10, 1
  update_foreign_keys, 10, 1
Altering `test`.`test`...
Creating new table...
Created new table test._test_new OK.
Altering new table...
Altered `test`.`_test_new` OK.
2014-08-26T13:40:56 Creating triggers...
2014-08-26T13:40:56 Created triggers OK.
2014-08-26T13:40:56 Copying approximately 5 rows...
2014-08-26T13:40:56 Dropping triggers...
2014-08-26T13:40:56 Dropped triggers OK.
2014-08-26T13:40:56 Dropping new table...
2014-08-26T13:40:56 Dropped new table OK.
`test`.`test` was not altered.
 (in cleanup) 2014-08-26T13:40:56 Error copying rows from `test`.`test` to `test`.`_test_new`: Threads_running=1 exceeds its critical threshold 1

2014-08-26T13:40:56 Dropping triggers...
2014-08-26T13:40:56 Dropped triggers OK.
`test`.`test` was not altered.
root@localhost#

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-1214