pt-table-checksum max load 20% rounds down

Bug #1253872 reported by Rob Smith on 2013-11-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit
Low
Frank Cizmich

Bug Description

When running pt-table-checksum or pt-online-schema on a server that is unused, setting the 20% max load fails due to it rounding down.

Example:
threads_running = 4
threads_running + 20% = 4.8
max_load == threads_running == 4

I purpose that this round up so it will run until max_threads are >=5 rather then the current 4.

What I would actually like to do is say:

max-load is 25 or 120% of threads_running, whichever is greater

Related branches

lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-max-load-20-percent-rounds-down-1253872
Daniel Nichter: Approve on 2014-08-04
Changed in percona-toolkit:
status: New → Fix Committed
importance: Undecided → Low
milestone: none → 2.2.10
assignee: nobody → Frank Cizmich (frank-cizmich)
Frank Cizmich (frank-cizmich) wrote :

Quick fix committed. Simply rounds up final value for now.

Changed in percona-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers