pt-upgrade re-prints Query classes for successive queries found

[Jay Janssen]

I *think* this is incorrect:

########################################################################
# Query class 9A4577992221A097
########################################################################

Reporting class because there are 1000 row diffs.

Total queries 3
Unique queries 3
Discarded queries 0

...

########################################################################
# Query class 9A4577992221A097
########################################################################

Reporting class because there are 1000 row diffs.

Total queries 4
Unique queries 4
Discarded queries 0

...

########################################################################
# Query class 9A4577992221A097
########################################################################

Reporting class because there are 1000 row diffs.

Total queries 5
Unique queries 5
Discarded queries 0

...

########################################################################
# Query class 9A4577992221A097
########################################################################

Reporting class because there are 1000 row diffs.

Total queries 6
Unique queries 6
Discarded queries 0

...

Each time it prints 3 of the queries that match (the last 3 maybe?) -- certainly makes for a long pt-upgrade output.

[Jay Janssen (jay-janssen)]

I *think* the issue is that report_class does not check for the 'reported' class attribute:

sub report_class {
   my ($self, %args) = @_;
   my $class = $args{class};
   my $reasons = $args{reasons};

+ return if $class->{reported};

Trying this hack now ^^

[Jay Janssen (jay-janssen)]

Just an update: the above hack seems to have done the trick:

-rw-rw-r-- 1 percona percona 2.0M Nov 7 07:41 upgrade-orig.txt
-rw-rw-r-- 1 percona percona 152K Nov 7 09:32 upgrade-new.txt

[Jay Janssen (jay-janssen)]

$ grep -a "Query class" upgrade-orig.txt |sort | uniq -c
     24 # Query class 1A32032FBD0F1480
      1 # Query class 1CBAAEA0F944EF18
      1 # Query class 2B75BA521C518CD0
      1 # Query class 32A5584E7EF63C52
      1 # Query class 35A72B82FD52FF36
      1 # Query class 675BF954739BF2D8
      4 # Query class 6AE28851D518C7F5
      3 # Query class 6C6B97ADA9109CE9
      2 # Query class 90361E9B1F5A9880
      1 # Query class 9279AFCEB1FD5B28
     28 # Query class 9A4577992221A097
      6 # Query class A50CDB2BEA418C6A
     28 # Query class BBDF46BD94A816A0
      1 # Query class CF8A862949641FD4
      1 # Query class D31B608E349A329B
      2 # Query class D3F15165B8904806
      5 # Query class D4EED660BD622B31
      1 # Query class D82EA4D82D4F7DF8
      2 # Query class DCA00531F6D0D41C
     15 # Query class DE8FF1476F1CF4B3
     11 # Query class E3A3649C5FAC418D

$ grep -a "Query class" upgrade-new.txt |sort | uniq -c
      1 # Query class 1A32032FBD0F1480
      1 # Query class 1CBAAEA0F944EF18
      1 # Query class 2B75BA521C518CD0
      1 # Query class 32A5584E7EF63C52
      1 # Query class 35A72B82FD52FF36
      1 # Query class 6AE28851D518C7F5
      1 # Query class 6C6B97ADA9109CE9
      1 # Query class 9279AFCEB1FD5B28
      1 # Query class 9A4577992221A097
      1 # Query class A50CDB2BEA418C6A
      1 # Query class BBDF46BD94A816A0
      1 # Query class D31B608E349A329B
      1 # Query class D3F15165B8904806
      1 # Query class D4EED660BD622B31
      1 # Query class DCA00531F6D0D41C
      1 # Query class DE8FF1476F1CF4B3
      1 # Query class E3A3649C5FAC418D

[Kenny Gryp (gryp)]

I have the same problem.

[Kenny Gryp (gryp)]

Now, wouldn't it be much better if we only validate for example 1000 queries for each fingerprint. All next queries are just not being executed for comparison.

Now I have to prepare my own slowlog to be able to limit how much I want to run.

[Nilnandan Joshi (nilnandan-joshi)]

Hi,

Is it possible for you to provide slow log / steps to reproduce this problem? Thanks.

[Launchpad Janitor (janitor)]

[Expired for Percona Toolkit because there has been no activity for 60 days.]

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-1171