Zero values causes "Invalid --set-vars value: var=0"

Bug #1182856 reported by Przemek on 2013-05-22
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to
Fix Released
Daniel Nichter

Bug Description

When trying to assign 0 to any variable using --set-vars option, getting "Invalid --set-vars value" message, even before the tool tries to connect to MySQL and apply the value.

How to reproduce:

pt-online-schema-change D=test,t=table --alter "engine=innodb" --set-vars="SQL_LOG_BIN=0" --dry-run
Invalid --set-vars value: SQL_LOG_BIN=0

The same using SQL_LOG_BIN=OFF or using any other value then 0 works.

I've tested on versions 2.2.1 and 2.2.2.

Related branches

Changed in percona-toolkit:
status: New → Triaged
importance: Undecided → High
milestone: none → 2.2.4
tags: added: all-tools
removed: pt-online-schema-change
summary: - pt-online-schema-change - unable to use 0 in --set-vars
+ Zero values causes "Invalid --set-vars value: var=0"
Changed in percona-toolkit:
status: Triaged → Fix Committed
assignee: nobody → Daniel Nichter (daniel-nichter)
Changed in percona-toolkit:
status: Fix Committed → Fix Released

Percona now uses JIRA for bug reports so this bug report is migrated to:

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers