pt-archiver should autolearn txn-size from limit if txn-size is not implied

Bug #1152559 reported by David Busby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Invalid
Undecided
Unassigned

Bug Description

As the summary suggests, if --limit=100 is specified at runtime and --txn-size is not, then --txn-size should default to the --limit value, instead of defaulting to 1.

Tags: pt-archiver
tags: added: pt-archiver
Changed in percona-toolkit:
status: New → Triaged
Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

On second look/thought, I'm not sure that --limit and --txn-size should be linked like this. --limit is "how many rows to select to archive", but --txn-size is "how many rows to commit for each txn", i.e. they do very different things. If one only wants to select the first 10,000 rows to archive, that doesn't imply they want them all in a 10k row txn; maybe they want 100 rows per txn.

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

Since this isn't a bug, I'm going to close it. Perhaps we could discuss this on the Percona forums, see what other people think? But my feeling atm is that --txn-size and --limit are not/should not be related like this.

Changed in percona-toolkit:
status: Triaged → Invalid
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-1089

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.