pt-query-advisor gives false, inconsistent warnings.

Bug #1130994 reported by Tramada Systems on 2013-02-21
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to
Won't Fix

Bug Description

Command: pt-query-advisor /tmp/sample4pt-query-advisor
Tools version: 2.1.9-1
MySQL version: 5.5.12
ALI.001 0xD6277F8BD92F2849

RES.002 0xD6277F8BD92F2849

# Profile
# ================== ==== ==== ==== ==========================================
# 0xD6277F8BD92F2849 1 1 0 select this_.booking_id as booking?_?_?_, ... from consultant this_ left outer join consultant consultant?_ on this_.default_buddy_consultant_id=consultant?_.consultant_id inner join branch branch?_ on this_.lvl?_branch_id=branch?_.branch_id left outer join branch branch?_ on branch?_.parent_branch_id=branch?_.branch_id inner join role role?_ on this_.role_id=role?_.role_id

RES.002 is incorrectly reported for the last one out of three queries in attached sample file. Actually none of these queries has LIMIT clause, although word "limit" is a part of some column names.

Furthermore, testing with six subset files containing:
 - single query per file
 - two queries per file (1+2, 1+3, 2+3)

resulted in:
 - NO warnings from single query files
 - RES.002 from 1+2 file
 - CLA.001 from 1+3 and 2+3 files

CLA.001 warnings are correct as the third query does not have WHERE clause.

Tramada Systems (its-p) wrote :
Tramada Systems (its-p) on 2013-02-22
tags: added: pt-query-advisor
tags: added: query-rule
Changed in percona-toolkit:
status: New → Triaged
Daniel Nichter (daniel-nichter) wrote :

We have decided to remove pt-query-advisor from 2.2 and refocus our efforts on the online version of the tool: The attached file is a little difficult to make sense of because the queries are so large and seem to run together. Could you isolate the particular issues and report them at please? Also, this means that any fixes for these queries will not be in the command line tool but rather the online tool.

Changed in percona-toolkit:
status: Triaged → Won't Fix
Tramada Systems (its-p) wrote :

Reported behaviour was detected whilst processing large "long queries" logs files and was replicated processing attached sample file.
As reported above, running query-advisor against single queries looks to be giving correct advice.

Percona now uses JIRA for bug reports so this bug report is migrated to:

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers