pt-stalk is too verbose, fills up log
Bug #1099933 reported by
Raghavendra D Prabhu
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
High
|
Daniel Nichter |
Bug Description
pt-stalk prints like
Check results: Threads_
every second.
Now, when running pt-stalk in daemon mode and it is writing to a
log, running it for a while can really fill up the logs.
It would be better to have a quiet option or verbosity levels.
I used like
if [[ "$matched" ]]; then
log "$msg"
fi
to print only when it is matched.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-quiet
- Daniel Nichter: Approve
-
Diff: 910 lines (+391/-87)13 files modifiedbin/pt-ioprofile (+15/-6)
bin/pt-mysql-summary (+15/-6)
bin/pt-pmp (+1/-1)
bin/pt-sift (+1/-1)
bin/pt-stalk (+53/-14)
bin/pt-summary (+15/-6)
lib/PerconaTest.pm (+33/-1)
lib/bash/log_warn_die.sh (+14/-5)
t/lib/bash/log_warn_die.sh (+83/-10)
t/pt-stalk/option_sanity.t (+24/-0)
t/pt-stalk/pt-stalk.t (+90/-33)
t/pt-stalk/samples/plugin002.sh (+5/-0)
util/test-bash-functions (+42/-4)
Changed in percona-toolkit: | |
milestone: | none → 2.1.9 |
Changed in percona-toolkit: | |
status: | Triaged → In Progress |
assignee: | nobody → Daniel Nichter (daniel-nichter) |
summary: |
- pt-stalk needs a quiet option + pt-stalk is too verbose, fills up log |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Normally this would be a feature request, but it's true: the tool is noisy with no way to turn off the noise, and that can lead to a very large log file. So it's a bug now! :-)