pt-table-checksum pxc same_node function incorrectly uses wsrep_sst_receive_address
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Brian Fraser |
Bug Description
pt-table-checksum has a 'same_node' function which seems to try to identify if one connection is actually the same node as another:
sub same_node {
my ($self, $cxn1, $cxn2) = @_;
my $sql = "SHOW VARIABLES LIKE 'wsrep\
PTDEBUG && _d($cxn1->name, $sql);
my (undef, $val1) = $cxn1->
PTDEBUG && _d($cxn2->name, $sql);
my (undef, $val2) = $cxn2->
return ($val1 || '') eq ($val2 || '');
}
Unfortunately in PXC, it is perfectly legal to leave wsrep_sst_
I'd suggest checking either (or both):
wsrep_node_name
wsrep_node_address (maybe)
Related branches
- Daniel Nichter: Approve
-
Diff: 98 lines (+33/-16)2 files modifiedbin/pt-table-checksum (+19/-9)
lib/Percona/XtraDB/Cluster.pm (+14/-7)
Changed in percona-toolkit: | |
milestone: | none → 2.2.2 |
importance: | High → Medium |
Changed in percona-toolkit: | |
assignee: | nobody → Brian Fraser (fraserbn) |
Changed in percona-toolkit: | |
status: | Triaged → In Progress |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
Thanks Jay. We'll look into this.