pt-table-checksum pxc same_node function incorrectly uses wsrep_sst_receive_address

Reported by Jay Janssen on 2013-01-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit
Medium
Brian Fraser

Bug Description

pt-table-checksum has a 'same_node' function which seems to try to identify if one connection is actually the same node as another:

sub same_node {
   my ($self, $cxn1, $cxn2) = @_;

   my $sql = "SHOW VARIABLES LIKE 'wsrep\_sst\_receive\_address'";
   PTDEBUG && _d($cxn1->name, $sql);
   my (undef, $val1) = $cxn1->dbh->selectrow_array($sql);
   PTDEBUG && _d($cxn2->name, $sql);
   my (undef, $val2) = $cxn2->dbh->selectrow_array($sql);

   return ($val1 || '') eq ($val2 || '');
}

Unfortunately in PXC, it is perfectly legal to leave wsrep_sst_receive_address as the default, which is AUTO and thus the same on all the nodes.

I'd suggest checking either (or both):
wsrep_node_name
wsrep_node_address (maybe)

Daniel Nichter (daniel-nichter) wrote :

Thanks Jay. We'll look into this.

tags: added: pt-table-checksum pxc
Changed in percona-toolkit:
status: New → Triaged
importance: Undecided → High
Changed in percona-toolkit:
milestone: none → 2.2.2
importance: High → Medium
Brian Fraser (fraserbn) on 2013-04-02
Changed in percona-toolkit:
assignee: nobody → Brian Fraser (fraserbn)
Changed in percona-toolkit:
status: Triaged → In Progress
Brian Fraser (fraserbn) on 2013-04-16
Changed in percona-toolkit:
status: In Progress → Fix Committed
Changed in percona-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers