pt-query-digest fails to parse timestamp with no query
Bug #1082599 reported by
Ovais Tariq
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
High
|
Daniel Nichter |
Bug Description
Brian I am reporting this as a bug in relation to what we talked about the problem I was facing with getting pt-query-digest to parse the slow log.
# pt-query-digest --version
pt-query-digest 2.1.5
The tool pt-query-digest fails to parse the slow log for queries if the queries are prefixed by SET timestamp=xxx. Removing the "SET timestamp=xxx" statements from the slow log fixes the issue and pt-query-digest then works as expected.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-slowlog-ts-bug-1082599
- Daniel Nichter: Approve
-
Diff: 288 lines (+194/-19)6 files modifiedbin/pt-query-digest (+18/-7)
lib/SlowLogParser.pm (+28/-7)
t/lib/SlowLogParser.t (+55/-2)
t/lib/samples/slowlogs/slow056.txt (+12/-0)
t/pt-query-digest/samples/slow056.txt (+68/-0)
t/pt-query-digest/slowlog_analyses.t (+13/-3)
tags: | added: percona-server |
Changed in percona-toolkit: | |
status: | New → Triaged |
milestone: | none → 2.1.8 |
Changed in percona-toolkit: | |
importance: | Undecided → High |
Changed in percona-toolkit: | |
assignee: | nobody → Daniel Nichter (daniel-nichter) |
Changed in percona-toolkit: | |
status: | Triaged → In Progress |
summary: |
- pt-query-digest fails to parse queries preceded with SET timestamp=x + pt-query-digest fails to parse timestamp with no query |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I would like to add that this bug affects those who use this feature of Percona Server: http:// www.percona. com/doc/ percona- server/ 5.5/diagnostics /slow_extended_ 55.html# slow_query_ log_timestamp_ always